Merge lp:~jan-philipp-fischer/openerp-connector-magento/7.0-image-url-encode into lp:~openerp-connector-core-editors/openerp-connector-magento/7.0
Proposed by
Jan-Philipp Fischer
Status: | Merged |
---|---|
Approved by: | Guewen Baconnier @ Camptocamp |
Approved revision: | 964 |
Merge reported by: | Guewen Baconnier @ Camptocamp |
Merged at revision: | not available |
Proposed branch: | lp:~jan-philipp-fischer/openerp-connector-magento/7.0-image-url-encode |
Merge into: | lp:~openerp-connector-core-editors/openerp-connector-magento/7.0 |
Diff against target: |
12 lines (+1/-1) 1 file modified
magentoerpconnect/product.py (+1/-1) |
To merge this branch: | bzr merge lp:~jan-philipp-fischer/openerp-connector-magento/7.0-image-url-encode |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Guewen Baconnier @ Camptocamp | code review | Approve | |
Review via email: mp+211715@code.launchpad.net |
Description of the change
If a Image URL has a special character like 'é' or 'ä' the import of product fails with "UnicodeEncodeE
With encode('utf8') the link is readable for the urllib.
To post a comment you must log in.
Thanks!