Merge lp:~jamestait/click-reviewers-tools/add-askubuntu-links into lp:click-reviewers-tools

[James Tait]

Add a handful of links to askubuntu questions to explain some of the rejection messages.

This branch adds links to a handful of questions on askubuntu, offering
explanations for some of the rejection messages developers will see in the
store.

It's worth checking out the questions and answers as well, to make sure they're
correct.

[Daniel Holbach (dholbach)]

Great work!

review: Approve

=== modified file 'check-names.list'
--- check-names.list	2015-11-11 16:05:23 +0000
+++ check-names.list	2015-11-24 12:17:23 +0000
@@ -78,8 +78,8 @@
 lint:manifest_icon_empty|
 lint:manifest_icon_present|
 lint:package_filename_arch_match|
-lint:package_filename_arch_valid|
-lint:package_filename_format|
+lint:package_filename_arch_valid|http://askubuntu.com/questions/685103/what-does-lint-package-filename-arch-valid-mean/685104
+lint:package_filename_format|http://askubuntu.com/questions/685049/what-does-lint-package-filename-format-mean/685050
 lint:package_filename_version_match|http://askubuntu.com/questions/417384/what-does-lint-package-filename-version-match-mean/417385
 lint:package yaml_architecture_valid|
 lint:package_yaml_icon_absolute_path|
@@ -110,8 +110,8 @@
 online_accounts:account-qml-plugin|
 online_accounts:account-service_hook|
 online_accounts:account-service_id|
-online_accounts:account-service_name|
-online_accounts:account-service_provider|
+online_accounts:account-service_name|http://askubuntu.com/q/697173
+online_accounts:account-service_provider|http://askubuntu.com/q/697173
 online_accounts:account-service_root|
 online_accounts:accounts_plugin|
 online_accounts:accounts_service|
@@ -145,7 +145,7 @@
 security:policy_vendor_matches_framework|
 security:policy_version_exists|
 security:policy_version_is_highest|http://askubuntu.com/q/562116/94326
-security:policy_version_matches_framework|
+security:policy_version_matches_framework|http://askubuntu.com/q/686347
 security:profile_name_length|
 security:redflag_fields|
 security:required_policy_groups_ubuntu_account_plugin|
@@ -153,7 +153,7 @@
 security:template_account_qml_plugin|
 security:template_exists|
 security:template_push_helper|
-security:template_valid|
+security:template_valid|http://askubuntu.com/q/671403
 security:template_with_policy_version|
 security:yaml_and_click|
 security:yaml_binaries|

=== modified file 'clickreviews/cr_lint.py'
--- clickreviews/cr_lint.py	2015-11-18 15:56:23 +0000
+++ clickreviews/cr_lint.py	2015-11-24 12:17:23 +0000
@@ -788,11 +788,12 @@
         t = 'info'
         n = self._get_check_name('package_filename_format')
         s = 'OK'
+        l = 'http://askubuntu.com/questions/685049/what-does-lint-package-filename-format-mean/685050'
         if len(tmp) != 3:
             t = 'warn'
             s = "'%s' not of form $pkgname_$version_$arch.[click|snap]" % \
                 click_package_bn
-        self._add_result(t, n, s)
+        self._add_result(t, n, s, l)
 
         t = 'info'
         n = self._get_check_name('package_filename_version_match')
@@ -818,6 +819,7 @@
         t = 'info'
         n = self._get_check_name('package_filename_arch_valid')
         s = 'OK'
+        l = 'http://askubuntu.com/questions/685103/what-does-lint-package-filename-arch-valid-mean/685104'
         if len(tmp) >= 3:
             if self.click_package.endswith('.snap'):
                 arch = tmp[2].partition('.snap')[0]
@@ -837,7 +839,7 @@
             t = 'warn'
             s = "could not determine architecture from '%s'" % \
                 os.path.basename(self.click_package)
-        self._add_result(t, n, s)
+        self._add_result(t, n, s, l)
 
         t = 'info'
         n = self._get_check_name('package_filename_arch_match')

=== modified file 'clickreviews/cr_online_accounts.py'
--- clickreviews/cr_online_accounts.py	2015-09-10 08:32:34 +0000
+++ clickreviews/cr_online_accounts.py	2015-11-24 12:17:23 +0000
@@ -340,6 +340,7 @@
             if t == 'error':
                 continue
 
+            l = 'http://askubuntu.com/q/697173'
             for tag in ['name', 'provider']:
                 t = 'info'
                 n = self._get_check_name(
@@ -348,7 +349,7 @@
                 if self.accounts[app][account_type].find(tag) is None:
                     t = 'error'
                     s = "Could not find '<%s>' tag" % tag
-                self._add_result(t, n, s)
+                self._add_result(t, n, s, l)
 
     def check_provider(self):
         '''Check provider'''

=== modified file 'clickreviews/cr_security.py'
--- clickreviews/cr_security.py	2015-11-11 15:40:49 +0000
+++ clickreviews/cr_security.py	2015-11-24 12:17:23 +0000
@@ -425,13 +425,14 @@
                 found_major = True
                 if m['policy_version'] != data['policy_version']:
                     t = 'error'
+                    l = 'http://askubuntu.com/q/686347'
                     s = '%s != %s (%s)' % (str(m['policy_version']),
                                            data['policy_version'],
                                            framework)
             if not found_major:
                 t = 'error'
                 s = "Invalid framework '%s'" % framework
-            self._add_result(t, n, s)
+            self._add_result(t, n, s, l)
 
     def check_template(self):
         '''Check template'''
@@ -450,6 +451,7 @@
             t = 'info'
             n = self._get_check_name('template_valid', extra=f)
             s = "OK"
+            l = 'http://askubuntu.com/q/671403'
             manual_review = False
             if 'template' not in m:
                 # If template not specified, we just use the default
@@ -463,7 +465,7 @@
                     and m['template'] in self.extraneous_ubuntu_templates:
                 t = 'warn'
                 s = "No need to specify '%s' template" % m['template']
-            self._add_result(t, n, s, manual_review=manual_review)
+            self._add_result(t, n, s, l, manual_review=manual_review)
 
             t = 'info'
             n = self._get_check_name('template_exists', extra=f)