Code review comment for lp:~jamesodhunt/upstart/upstart-monitor

On 20 March 2013 21:52, Steve Langasek <email address hidden> wrote:
> I notice that the UI is hand-coded in python. Are you concerned about the maintainability of this, vs. using glade and gtkbuilder?
>

Well, If one uses glade, one should be prepared to keep local builds
and send patches to upstream when it crashes on loading ubiquity.ui
for example =)

I know Colin, mostly edits gtkbuilder xml with vim. Which is good a well.

I guess long term, it might be more appropriate to do it in Qt5, once
that's on the default desktop and the iso. At least Qt UI definitions
& GUI editor do not crash.

Anyway the UI code here is quite short and easy to understand /
extend. And mostly deal with list-store, which is a pain to code up
right in Glade. One nitpick would be to use GtkGrid instead of GtkBox.
As the Box is deprecated and you will notice weird sizing problems
(just look for the tonne of bugs mpt filed about dialogs/windows being
too tall for their width).

Regards,

Dmitrijs.