Code review comment for lp:~jamesodhunt/upstart/fix-libupstart

Revision history for this message
Dimitri John Ledkov (xnox) wrote :

* Remove ; at the end of rule "cp $< $@;" for aesthetic reasons =)
* upstart-dbus.h should be added to BUILT_SOURCES variable
* Fails to compile:

make[3]: Entering directory `/home/xnox/canonical/upstart/upstart/lib'
  CC test_libupstart.o
In file included from tests/test_libupstart.c:37:0:
./upstart.h:27:34: fatal error: upstart/upstart-dbus.h: No such file or directory
 #include "upstart/upstart-dbus.h"
                                  ^
compilation terminated.
make[3]: *** [test_libupstart.o] Error 1

review: Needs Fixing

« Back to merge proposal