Code review comment for lp:~jamesodhunt/upstart/bug-980917-the-bug-that-would-not-die

Revision history for this message
Steve Langasek (vorlon) wrote :

@@ -290,7 +286,6 @@
                 */
                system_mknod ("/dev/null", (S_IFCHR | 0666), makedev (1, 3));
                system_mknod ("/dev/tty", (S_IFCHR | 0666), makedev (5, 0));
- system_mknod ("/dev/console", (S_IFCHR | 0600), makedev (5, 1));
                system_mknod ("/dev/kmsg", (S_IFCHR | 0600), makedev (1, 11));

                /* Set the standard file descriptors to the ordinary console device,

Per https://code.launchpad.net/~jamesodhunt/upstart/bug-980917-reworked/+merge/118132/comments/253998, we should also omit the mknod of /dev/null and /dev/kmsg, which are guaranteed to be provided at the time devtmpfs is mounted.

I'll fix this up and push.

review: Approve

« Back to merge proposal