Code review comment for lp:~jamesodhunt/upstart/bug-530779

>> Upstart does not depend on PR_SET_CHILD_SUBREAPER being
>> available on the running kernel - the test suite shouldn't
>> either. The test needs to be skipped if this facility is
>> unavailable, or it needs to be rewritten to avoid subreaper
>> entirely.

> Fixed.

This is not fixed. You've adjusted the test suite to not fail if PR_SET_CHILD_SUBREAPER is not *defined* at build time; this does not address the problem of it being *unsupported* by the running kernel. The 'assert0 (prctl (PR_SET_CHILD_SUBREAPER, 1))' must be dropped from the test suite, and be replaced by a check that skips the test if it's unavailable.

This probably calls for the test to be broken out into a separate function so that it can be skipped sensibly.