Ubuntu
upstart package

Code review comment for lp:~jamesodhunt/ubuntu/saucy/upstart/1.9.1

  1. Saucy (13.10)
  2. 1.9.1
  3. Merge into saucy
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

* I think we do need to override dh_makeshlibs call and specify wanted version number (1.9.1) similar to libnih, since at the moment the symbols ended up to be over-versioned =)

libupstart.so.1 libupstart1 #MINVER#
 LIBUPSTART_1.0.0@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_com_ubuntu_Upstart0_6_Job@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_all@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_all_instances@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_all_instances_sync@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_all_sync@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_author@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
 job_class_get_author_sync@LIBUPSTART_1.0.0 1.9.1-0ubuntu1
....

* dpkg-maintainer-helper to remove the config file needs to also be called in upstart.preinst and upstart.postrm.

Otherwise looks good. I guess it's ok to merge this branch now, but above two issues need to be fixed up. You or me can do that on lp:ubuntu/upstart directly.

review: Approve

« Back to merge proposal