Code review comment for lp:~jamesodhunt/ubuntu/saucy/upstart/1.9.1

* I noticed SELINUX support is in ubuntu branch, but not
  upstream. Yet, apparmor support is upstream. Is SELINUX not needed
  upstream?

* libupstart1 control:
  One shouldn't normally use Pre-Depends, typically one uses
  Depends. Pre-Depends are used only in very unusual circumstances
  when additional guarantees are needed (all dependencies configured
  before this package is unpacked). Instead the fields should look
  like:

  Pre-Depends: $(misc:Pre-Depends)
  Depends: $(misc:Depends), $(shlibs:Depends)

  There is no need to list libnih-dbus1 dependancy, as the correct one
  is already genereated by shlibs:Depends, see libupstart1.substvars:
  "shlibs:Depends=libc6 (>= 2.2.5), libdbus-1-3 (>= 1.2.16), libnih-dbus1 (>= 1.0.0), libnih1 (>= 1.0.0)"

* upstart-dbus-bridge.conf removal:

  Since it's a conffile, it will not be automatically removed from
  disk by dpkg, such that upgrading to this version of upstart will
  keep that file. Thus it needs to be properly removed as done with
  dbus-reconnect.conf in upstart postinst,postrm,preinst. Instead of
  the "old" way of doing it, it's now possible to use
  dpkg-maintscript-helper instead.

* Incomplete Multi-Arch:
  Packages marked as Multi-Arch, clashing files must be identical, if
  they are different they should be shipped in arch-qualified
  locations. One file /usr/lib/pkgconfig/libupstart.pc is different across architectures:
  -libdir=${prefix}/lib/x86_64-linux-gnu
  +libdir=${prefix}/lib/i386-linux-gnu
  Thus it should be instead shipped in /usr/lib/$(DEB_HOST_MULTIARCH)/pkgconfig