Code review comment for lp:~jamesodhunt/snappy/log-commands-that-change-system-state

Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for working on this!

I started reviewing this branch but I think this needs a quick sync with Sergio before I continue. By doing most of the logging in cmd/snappy webdm will have to duplicate that code.

It seems worthwhile to talk about moving the cmd/ bits into snappy/partition so that he automatically benefits.

I still have some inline comments, it seems like there is value in extracting some of the common pattern(s) into helpers.

review: Needs Information

« Back to merge proposal