Code review comment for lp:~jamesj/charms/trusty/haproxy/xenial-support

James,

Thanks for this contribution! It will be great to see the haproxy charm get support for Xenial.

This was missing a deploy test for Xenial, and I hit some errors while testing it. I created a MP against this proposed branch with a Xenial test, test fixes, and adding the series to the metadata: https://code.launchpad.net/~johnsca/charms/trusty/haproxy/xenial-support/+merge/299470 If that looks good to you, please merge it into your proposed branch and it will automatically update this MR.

I tried to (trivially) add support for Precise as well, but ran into an error: http://pastebin.ubuntu.com/18729639/ I didn't look any deeper into what the delta was between the Precise version of this charm and this one.

With those suggested fixes, I think this would be good. Because of the new process for promulgation, though, we will need one of the maintainers (Juan or Tom) to publish this charm into the store under their (or an appropriate group) namespace before we can move forward with merging and re-promulgation.