Code review comment for lp:~jamesj/account-banking/us-canada-payments

Hi James,

please excuse me for commenting on your own branches, but I think you are interested in merging with banking-addons or account-banking eventually. Therefore I have a comment on your change to account_banking/account_banking_view.xml:8

You signaled the issue of the 404 on the SWIFT online lookup in lp:914922. Your solution here is to disable the on_change method. I would prefer to keep the on-change method, but disable the online function until we have found a viable alternative and parametrized the online lookup like you suggested in the bug report. See the following branch:

https://code.launchpad.net/~banking-addons-team/banking-addons/lp914922

If you feel that you must disable the on-change method, you can simply replace the field again in the HSBC module.

Cheers,
Stefan.