The main issue seems to be that the service is called thumbnailer-service. It implies that it would provide thumbnailing services for all files. However it must not do that because that would open a way for confined applications to access files outside its sandbox. For album art this is not an issue because album art images are fully public data. Maybe we should call this albumart-service or alternatively develop a confinement security policy (which is a lot of work).
That being said, here are a few minor things:
"__ThumbnailerIngoreMe" has a typo.
#ifndef PLUGIN_H is a bit too generic and may clash, should be THUMBNAILERPLUGIN_H or somesuch.
The main issue seems to be that the service is called thumbnailer- service. It implies that it would provide thumbnailing services for all files. However it must not do that because that would open a way for confined applications to access files outside its sandbox. For album art this is not an issue because album art images are fully public data. Maybe we should call this albumart-service or alternatively develop a confinement security policy (which is a lot of work).
That being said, here are a few minor things:
"__ThumbnailerI ngoreMe" has a typo.
#ifndef PLUGIN_H is a bit too generic and may clash, should be THUMBNAILERPLUGIN_H or somesuch.