Code review comment for lp:~jamesh/thumbnailer/dbus-service

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

Here's something that bothers me:

static void getAlbumArt(unique_gobj<TNThumbnailer> iface,
  unique_gobj<GDBusMethodInvocation> invocation,

This function takes a unique_gobj by value but unique_gobj does not have a copy constructor or operator=. Maybe it invokes the move constructor because it is called with a temporary object?

Anyhow, it works so if no-one can give a feasible case why this would break I'm fine with merging this.

review: Approve

« Back to merge proposal