Code review comment for lp:~jamesh/thumbnailer/dbus-service

Revision history for this message
Jussi Pakkanen (jpakkane) wrote :

> catch (std::exception &e)

The recommended practice is to catch exceptions by const ref rather than plain ref.

> std::thread t(&getCoverArt,

This may throw, please wrap in try/catch.

> // This should be replaced with actual lookup code.

I think it has been. :)

> /**
> + * A class that sends a broadcast signal that the state of media
> + * files has changed.
> + */

This is still from InvalidationSender and thus not accurate.

review: Needs Fixing

« Back to merge proposal