Code review comment for lp:~jamesh/storm/django-support

Revision history for this message
Jamu Kakar (jkakar) wrote :

[1]

+__all__ = ["get_store"]

"get_store_uri" should be defined here too, in storm/django/stores.py.

[2]

+ def tearDown(self):
+ transaction.abort()
+ self.drop_tables()
+ settings._target = None
+ global_zstorm._reset()
+ stores.have_configured_stores = False
+ transaction.manager.free(transaction.get())
+ super(DjangoBackendTests, self).tearDown()

It might be worth making ZStorm._reset public so that we can access
one less private member here.

This is great. I'm looking forward to using it. +1!

review: Approve

« Back to merge proposal