Code review comment for lp:~jamesh/storm/bug-585704
Revision history for this message
| James Henstridge (jamesh) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
73416ba
(Get the code!)
John: I assume you'd get that error without my fix if you move to the new version of psycopg2.
This branch doesn't change the way Storm passes byte strings down to psycopg2 (it has always wrapped them in psycopg2.Binary() objects) -- it just fixes a few cases inside Storm where we got byte string vs. unicode string wrong. Switching those custom variable types to use unicode strings was the correct fix for the U1 code.