Code review comment for lp:~jamesh/mediascanner2/model-auto-update

Jussi Pakkanen (jpakkane) wrote :

Looking good. Only nitpick:

ModelStatus status_;

Why the trailing underscore? No other variable in the class has decoration. If it's this:

void StreamingModel::setStatus(StreamingModel::ModelStatus status)

then change the argument to new_status or something similar.

Regardless of that, this looks fine.

review: Approve

« Back to merge proposal