Code review comment for lp:~jamesh/mediascanner/qml-plugin

Revision history for this message
James Henstridge (jamesh) wrote :

Thanks for everyone's feedback.

@mhr3: I've added the explicit QQmlEngine::setObjectOwnership() calls, and verified that the MediaFileWrapper instances are being destroyed when my test program exits. That would seem to indicate that it can handle a QList<QObject*> okay.

I agree that we should provide some QAbstractItemModel based APIs, but at this point I just wanted to get the basics working so we could ask the music-app guys what kind of interface they're after. The alternative would be to spend a lot of time on something they ultimately can't use.

@timo: thanks for the pointers. I think I've got the install directory and package name fixed up now.

« Back to merge proposal