Code review comment for lp:~jamesh/mediascanner/qml-plugin

Revision history for this message
Michal Hruby (mhr3) wrote :

153 + Q_INVOKABLE QList<QObject*> query(const QString &q, MediaType type);

It'd probably be better if this was returning a real model instance - subclass of QAbstractItemModel, it's not clear to me whether QML would know how to manage the object lifecycle of the List + ObjectPtrs.

« Back to merge proposal