Code review comment for lp:~jamesh/django-openid-auth/sanitise-url

Revision history for this message
James Henstridge (jamesh) wrote :

I'm upgrading my laptop to Lucid to try and reproduce the bug.

As far as the bug goes, the view that is being rendered by the test prints response.user.username. If we aren't authenticated, then request.user will be an AnonymousUser instance, whose username attribute is the empty string. If this is a real bug rather than a quirk of the test environment, then it is a serious bug.

That said, it is a bug that is orthogonal to this merge proposal. Given that it does pass on Karmic, I think merging should be fine.

« Back to merge proposal