> Functionally, it's great and achieves what the description promises with a
> very minimal cost. Very nice improvement indeed!
> Code wise, only a couple of details:
> - it would be nice to unload the Image once the thumbnail has been loaded;
> although it is a very small save of a 32x32 image
I've added an onStatusChanged handler to the image that resets the filename to "" whenever the status changes to Image.Ready.
> - the Image {}'s id could be more explicit than just 'thumbnail', for example
> 'preCachingThumbnail' or something
Done.
> - also a small comment next to the Image explaining its purpose and
> specifically why a sourceSize of 32x32 suffices to provide all the benefits
> would be extra useful
Thanks for the review.
> Functionally, it's great and achieves what the description promises with a
> very minimal cost. Very nice improvement indeed!
> Code wise, only a couple of details:
> - it would be nice to unload the Image once the thumbnail has been loaded;
> although it is a very small save of a 32x32 image
I've added an onStatusChanged handler to the image that resets the filename to "" whenever the status changes to Image.Ready.
> - the Image {}'s id could be more explicit than just 'thumbnail', for example bnail' or something
> 'preCachingThum
Done.
> - also a small comment next to the Image explaining its purpose and
> specifically why a sourceSize of 32x32 suffices to provide all the benefits
> would be extra useful
Done.