Merge lp:~jamesbeedy/charms/trusty/docker/fix_apt_dep into lp:charms/trusty/docker

Proposed by james beedy
Status: Needs review
Proposed branch: lp:~jamesbeedy/charms/trusty/docker/fix_apt_dep
Merge into: lp:charms/trusty/docker
Diff against target: 12 lines (+3/-0)
1 file modified
playbooks/install-or-upgrade.yaml (+3/-0)
To merge this branch: bzr merge lp:~jamesbeedy/charms/trusty/docker/fix_apt_dep
Reviewer Review Type Date Requested Status
Review Queue (community) automated testing Needs Fixing
Kevin W Monroe Needs Information
Review via email: mp+300544@code.launchpad.net

Description of the change

Add apt dep libssl-dev. Fixes install-hook failure & Bug #1604618.

To post a comment you must log in.
Revision history for this message
Matt Bruzek (mbruzek) wrote :

Hello James,

The code merged cleanly and was a very small change, but still see errors when deploying the local charm.

2016-07-27 22:14:11 INFO install build/temp.linux-x86_64-2.7/_openssl.c:429:30: fatal error: openssl/opensslv.h: No such file or directory

After sshing to the unit the install-or-upgrade.yaml file was updated with the change, but the libssl-dev was not installed by the install hook.

For reference here is an AskUbuntu question that looks similar.: http://askubuntu.com/questions/797351/fatal-error-openssl-opensslv-h-no-such-file-or-directory-compiling-mitmproxy

It seems the system needs a few additional packages as well:
sudo apt-get install python-pip python-dev libffi-dev libssl-dev libxml2-dev libxslt1-dev libjpeg8-dev zlib1g-dev

We just need to find out how to get those packages installed early enough so the install hook does not fail.

Revision history for this message
Matt Bruzek (mbruzek) wrote :

James the containers team re-wrote this charm to reactive http://github.com/juju-solutions/layer-docker.git we would love for you to build that charm and see if it works for your needs. We plan on pushing this charm in the near future.

Revision history for this message
james beedy (jamesbeedy) wrote :

Hey Matt,

Thanks for looking into this. Thats great news! I'll give her a
build/deploy here shortly!

On Wed, Jul 27, 2016 at 4:02 PM, Matt Bruzek <email address hidden>
wrote:

> James the containers team re-wrote this charm to reactive
> http://github.com/juju-solutions/layer-docker.git we would love for you
> to build that charm and see if it works for your needs. We plan on pushing
> this charm in the near future.
> --
>
> https://code.launchpad.net/~jamesbeedy/charms/trusty/docker/fix_apt_dep/+merge/300544
> You are the owner of lp:~jamesbeedy/charms/trusty/docker/fix_apt_dep.
>

Revision history for this message
Kevin W Monroe (kwmonroe) wrote :

Setting this as Needs Info because I'm not clear if this is still a valid bug. Does the layered docker charm work, and if so, is there any need to track down the right place to add libssl-dev to the non-layered charm?

review: Needs Information
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5017/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5025/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4814/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5033/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4821/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4826/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5040/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4830/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5044/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4834/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5047/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4837/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-aws/5049/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4839/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4840/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4841/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4843/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4842/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4845/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4846/

review: Needs Fixing (automated testing)
Revision history for this message
Review Queue (review-queue) wrote :

This item has failed automated testing! Results available here http://juju-ci.vapour.ws/job/charm-bundle-test-lxc/4848/

review: Needs Fixing (automated testing)

Unmerged revisions

11. By james beedy

add libssl-dev dep

Fixes Bug #1604618

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'playbooks/install-or-upgrade.yaml'
2--- playbooks/install-or-upgrade.yaml 2015-07-10 20:52:16 +0000
3+++ playbooks/install-or-upgrade.yaml 2016-07-19 23:45:00 +0000
4@@ -9,5 +9,8 @@
5 - name: install virtualenv
6 apt: name=virtualenvwrapper state=present
7
8+- name: install libssl-dev
9+ apt: name=libssl-dev state=present
10+
11 - name: Install docker-py
12 pip: "name=docker-py virtualenv={{ charm_dir}}/.venv"

Subscribers

People subscribed via source and target branches

to all changes: