Merge lp:~james-w/summit/multiple-sprints into lp:summit

[James Westby]

Hi,

Here's my largest branch yet.

This one extends the model to allow specifying multiple
Launchpad sprints for one summit.

The rationale for this is again Linaro. We would like our
own Launchpad sprint so that we can give people registering
useful information about our event etc.

We still need this to update the event in summit though, so
this change allows for multiple sprints to be queried
for one event. The results are unified in to the one event.

This retains the same behavior as before if the new model
isn't used.

In addition it cleans up some of the code and adds some
tests, fixing a couple of latent bugs along the way.

Thanks,

James

[Michael Hall (mhall119)]

======================================================================
ERROR: test_update_meeting_skips_no_name (summit.schedule.tests.SummitModelTestCase)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/mhall/projects/Ubuntu/summit/current_work/summit/../summit/schedule/tests.py", line 583, in test_update_meeting_skips_no_name
    self.assertIs(None, meeting)
AttributeError: 'SummitModelTestCase' object has no attribute 'assertIs'

review: Needs Fixing

[lp:~james-w/summit/multiple-sprints]

165. By James Westby on 2011-09-15

Use assertEqual as assertIs is too new.

[James Westby (james-w)]

Hi,

I pushed up a fix to use assertEqual, which will suffice.

Thanks,

James

[Michael Hall (mhall119)]

17:09 < mhall119> james_w: my only concern about the multi-sprint is that once you
                  add a Sprint record, you lose the default which uses the summit name
17:09 < mhall119> this may cause confusion
17:09 < james_w> hmm
17:09 < mhall119> we'll just have to make sure people know about it
17:09 < james_w> ok
17:10 < mhall119> so right now we'll have uds-p spring
17:10 < mhall119> sprint
17:10 < james_w> I would have put some text on the admin page, but I wasn't sure how
17:10 < mhall119> and if Marianna adds the Linaro sprint, suddenly it won't check the
                  uds-p sprint anymore
17:11 < mhall119> I think just making them aware will suffice for this cycle, but we
                  might want to discuss how to keep it consistent going forward
17:11 < mhall119> either dropping the use of a default, or adding the default as a
                  sprint on initial save of a Summit object
17:12 < james_w> ah, that's a good idea
17:12 < james_w> I'll set this one up, so it won't be a problem unless anyone changes
                 them

[Michael Hall (mhall119)]

User-experience concerns listed in the comments, but functionally it looks good, so I'm approving.

review: Approve