Merge lp:~james-w/summit/dont-autoschedule-private into lp:summit

Proposed by James Westby
Status: Merged
Approved by: Michael Hall
Approved revision: 160
Merge reported by: Michael Hall
Merged at revision: not available
Proposed branch: lp:~james-w/summit/dont-autoschedule-private
Merge into: lp:summit
Diff against target: 13 lines (+3/-0)
1 file modified
summit/schedule/models/meetingmodel.py (+3/-0)
To merge this branch: bzr merge lp:~james-w/summit/dont-autoschedule-private
Reviewer Review Type Date Requested Status
Michael Hall (community) Approve
Review via email: mp+75256@code.launchpad.net

Commit message

Stops the auto-scheduler from acting on private meetings.

Description of the change

Hi,

This change stops the auto-scheduler from acting on private meetings.

It would be great to have it do the right thing, but stopping it
doing the right thing is easier, and we're ok with manual scheduling
of private meetings.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Michael Hall (mhall119) wrote :

Looks good, but will require a manual merge because of prior branches having landed

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'summit/schedule/models/meetingmodel.py'
2--- summit/schedule/models/meetingmodel.py 2011-09-02 20:53:38 +0000
3+++ summit/schedule/models/meetingmodel.py 2011-09-13 20:59:23 +0000
4@@ -392,6 +392,9 @@
5
6 def try_schedule(self):
7 """Try to schedule this meeting in a suitable room."""
8+ if self.private:
9+ print "Not scheduling private meeting: %s" % self
10+ return
11 open_rooms = self.summit.room_set.filter(type__exact='open')
12
13 tracks = self.tracks.all()

Subscribers

People subscribed via source and target branches