Code review comment for lp:~james-w/python-oops-amqp/bson-compat

Hi James,

I'll land and organise a release.

On Fri 10 Feb 2012 14:58:19 EST, James Westby wrote:
> On Fri, 10 Feb 2012 01:24:17 -0000, Ian Booth <email address hidden> wrote:
>> Review: Approve code
>
> Thanks for the review. Would you be able to land the change for me as I
> don't have access to do so? A release would be really nice too, but I
> can always add the patch to our packaging.
>
>> Thanks for this change to improve the robustness of our tools. It
>> looks like a nice solution to a problem not of our making. I wonder,
>> do we have a preferred bson library or can people just install
>> whatever and hence we need this fix to cope with that?
>
> The pymongo version seems to be winning (is packaged, is much faster, is
> usually the one people refer to from what I can see.) That's not the
> version that was in use though unfortunately.
>
> People can install whatever, and if you use the python tools it's a bit
> of a crapshoot which one you end up with.
>
> The reason we are interested is that we're trying to depend on this
> stuff, and we want it packaged up. As I have it now I have packaged the
> non-pymongo version, but it conflicts with the pymongo version of the
> code, and u1 already use that version. This will allow us to have the
> package depend on the pymongo version.
>
> Thanks,
>
> James
>