Merge lp:~james-w/pkgme/less-mandatory-information into lp:pkgme

Proposed by James Westby
Status: Merged
Merged at revision: 48
Proposed branch: lp:~james-w/pkgme/less-mandatory-information
Merge into: lp:pkgme
Prerequisite: lp:~james-w/pkgme/further-test-fixes
Diff against target: 30 lines (+3/-3)
1 file modified
pkgme/info_elements.py (+3/-3)
To merge this branch: bzr merge lp:~james-w/pkgme/less-mandatory-information
Reviewer Review Type Date Requested Status
pkgme committers Pending
Review via email: mp+46420@code.launchpad.net

Description of the change

Hi,

Here's a small branch to reduce the number of required info elements.

Most things can have a default that will work, even if it's not useful information
(e.g. maintainer.) This will make it easier for backend authors to get started.

The only remaining required element is the package name. That could be given
a default of "package" or something, but I think that's going a bit far.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

What do you think about taking the email default from email.utils.formataddr() on the DEBEMAIL and DEBFULLNAME envars if they exist? Perhaps fall back to $NAME for the latter?

Revision history for this message
James Westby (james-w) wrote :

On Mon, 24 Jan 2011 19:20:09 -0000, Barry Warsaw <email address hidden> wrote:
> What do you think about taking the email default from
> email.utils.formataddr() on the DEBEMAIL and DEBFULLNAME envars if
> they exist? Perhaps fall back to $NAME for the latter?

I think that makes sense.

There's code in bzr-builder that actually implements the same as "dch"
does for this, which is probably the right way to go.

How do you feel about adding that later?

Thanks,

James

Revision history for this message
Barry Warsaw (barry) wrote :

On Jan 24, 2011, at 07:31 PM, James Westby wrote:

>On Mon, 24 Jan 2011 19:20:09 -0000, Barry Warsaw <email address hidden> wrote:
>> What do you think about taking the email default from
>> email.utils.formataddr() on the DEBEMAIL and DEBFULLNAME envars if
>> they exist? Perhaps fall back to $NAME for the latter?
>
>I think that makes sense.
>
>There's code in bzr-builder that actually implements the same as "dch"
>does for this, which is probably the right way to go.
>
>How do you feel about adding that later?

Sounds good. Probably should open a bug report on that for tracking
purposes. Then commit this branch as is.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'pkgme/info_elements.py'
--- pkgme/info_elements.py 2010-12-17 21:19:36 +0000
+++ pkgme/info_elements.py 2011-01-16 19:12:54 +0000
@@ -64,7 +64,7 @@
64 Name <email>64 Name <email>
6565
66 """66 """
67 required = True67 default = "A Person <someone@example.com>"
6868
6969
70class Homepage(InfoElement):70class Homepage(InfoElement):
@@ -98,7 +98,7 @@
98 to build on specific architectures only.98 to build on specific architectures only.
9999
100 """100 """
101 required = True101 default = "any"
102102
103103
104class Depends(InfoElement):104class Depends(InfoElement):
@@ -111,7 +111,7 @@
111111
112 name = "description"112 name = "description"
113 description = "The description of the package."113 description = "The description of the package."
114 required = True114 default = "a package"
115115
116116
117class Version(InfoElement):117class Version(InfoElement):

Subscribers

People subscribed via source and target branches

to all changes: