Code review comment for lp:~james-w/pkgme/careful-tar-exclude

Revision history for this message
Michael Vogt (mvo) wrote :

This is a drive-by review. The fix and the tests look fine!

The only remark is that it took me some seconds to figure out what:

  def get_all_paths(path):
    """Get all the paths that are needed for `path`.

is doing. Maybe something like:
"""Get all the paths that are needed to build/mkdir `path`.
"

review: Approve

« Back to merge proposal