Code review comment for lp:~james-w/pkgme-devportal/dict-api

Revision history for this message
Jonathan Lange (jml) wrote :

Hey,

Thanks for doing this. The dict-based API is much clearer.

The branch adds a bunch of new functions / methods that don't have direct test coverage AFAICT. Can you please add tests for these before this branch lands?

 libdep_mapping_for_deb
 get_arch_libdep_mapping
 extract_deb_control
 get_file_contents
 libdep_mapping_from_symbols

It might also be a good idea to maybe make some new modules and move things around a bit. Another day, I think.

cheers,
jml

review: Needs Fixing

« Back to merge proposal