Merge lp:~james-w/linaro-image-tools/hwpack-packaging into lp:linaro-image-tools/11.11

Proposed by James Westby
Status: Merged
Merged at revision: 99
Proposed branch: lp:~james-w/linaro-image-tools/hwpack-packaging
Merge into: lp:linaro-image-tools/11.11
Diff against target: 118 lines (+48/-5)
7 files modified
.bzr-builddeb/default.conf (+2/-0)
debian/changelog (+1/-2)
debian/control (+15/-2)
debian/linaro-image-tools.install (+2/-0)
debian/python-hwpack.install (+1/-0)
debian/rules (+3/-1)
setup.py (+24/-0)
To merge this branch: bzr merge lp:~james-w/linaro-image-tools/hwpack-packaging
Reviewer Review Type Date Requested Status
Guilherme Salgado (community) code Approve
Review via email: mp+36598@code.launchpad.net

Description of the change

Hi,

This adds the hardware pack code the the packaging, so that everyone
can make use of it.

I added a second package for the library to comply better with the
python policy.

The setup.py is very minimal, but it's all that's really needed for this.

Thanks,

James

To post a comment you must log in.
Revision history for this message
Guilherme Salgado (salgado) wrote :

This looks good to me (although I'm no packaging expert), but I think we need to add python-argparse to python-hwpack's Build-Depends and Depends, no? Without that I wasn't able to build

review: Approve (code)
Revision history for this message
James Westby (james-w) wrote :

On Mon, 27 Sep 2010 17:23:39 -0000, Guilherme Salgado <email address hidden> wrote:
> Review: Approve code
> This looks good to me (although I'm no packaging expert), but I think
> we need to add python-argparse to python-hwpack's Build-Depends and
> Depends, no? Without that I wasn't able to build

Good point, I missed it because of a misplaced grep.

Thanks,

James

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== added directory '.bzr-builddeb'
=== added file '.bzr-builddeb/default.conf'
--- .bzr-builddeb/default.conf 1970-01-01 00:00:00 +0000
+++ .bzr-builddeb/default.conf 2010-09-24 20:41:47 +0000
@@ -0,0 +1,2 @@
1[BUILDDEB]
2native=True
03
=== modified file 'debian/changelog'
--- debian/changelog 2010-09-15 23:44:53 +0000
+++ debian/changelog 2010-09-24 20:41:47 +0000
@@ -11,8 +11,7 @@
11 itself can run as non-root as intended.11 itself can run as non-root as intended.
1212
13 [ James Westby ]13 [ James Westby ]
14 * Add a linaro-hwpack-creation script for the creation of hardware packs.14 * Add a linaro-hwpack-create script for the creation of hardware packs.
15 Not yet installed in the binary packages.
1615
17 -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 14 Sep 2010 17:01:49 -070016 -- Steve Langasek <steve.langasek@ubuntu.com> Tue, 14 Sep 2010 17:01:49 -0700
1817
1918
=== modified file 'debian/control'
--- debian/control 2010-09-07 08:52:42 +0000
+++ debian/control 2010-09-24 20:41:47 +0000
@@ -1,10 +1,11 @@
1Source: linaro-image-tools1Source: linaro-image-tools
2Section: devel2Section: devel
3Priority: optional3Priority: optional
4Build-Depends: debhelper (>= 7)4Build-Depends: debhelper (>= 7.0.50~), python-all, python-apt, python-testtools
5Standards-Version: 3.9.15Standards-Version: 3.9.1
6Maintainer: Linaro Developers <linaro-dev@lists.linaro.org>6Maintainer: Linaro Developers <linaro-dev@lists.linaro.org>
7Vcs-Bzr: 7Vcs-Bzr:
8XS-Python-Version: >=2.5
89
9Package: linaro-image-tools10Package: linaro-image-tools
10Architecture: all11Architecture: all
@@ -13,10 +14,22 @@
13 uuid-runtime,14 uuid-runtime,
14 wget,15 wget,
15 uboot-mkimage,16 uboot-mkimage,
16 realpath17 realpath,
18 python,
19 python-hwpack
17Description: collection of tools to work with Linaro images20Description: collection of tools to work with Linaro images
18 This package offers a set of tools for use with Linaro images.21 This package offers a set of tools for use with Linaro images.
19 .22 .
20 The provided linaro-media-create command allows writing Linaro images23 The provided linaro-media-create command allows writing Linaro images
21 to a SD card, or generating an image file which you can boot in QEMU.24 to a SD card, or generating an image file which you can boot in QEMU.
2225
26Package: python-hwpack
27Architecture: all
28Section: python
29Depends: ${python:Depends}, python-apt, ${misc:Depends}
30Description: python library for the creation of hardware packs
31 Hardware packs allow for the distribution of packages to be combined with
32 an image to create a root filesystem at a later date.
33 .
34 This package provides a python library to aid with the creation of hardware
35 packs.
2336
=== modified file 'debian/linaro-image-tools.install'
--- debian/linaro-image-tools.install 2010-08-31 20:50:14 +0000
+++ debian/linaro-image-tools.install 2010-09-24 20:41:47 +0000
@@ -1,1 +1,3 @@
1linaro-media-create usr/bin1linaro-media-create usr/bin
2linaro-hwpack-install usr/bin
3linaro-hwpack-create usr/bin
24
=== added file 'debian/python-hwpack.install'
--- debian/python-hwpack.install 1970-01-01 00:00:00 +0000
+++ debian/python-hwpack.install 2010-09-24 20:41:47 +0000
@@ -0,0 +1,1 @@
1usr/lib/python*/dist-packages/hwpack
02
=== modified file 'debian/rules'
--- debian/rules 2010-08-31 20:50:14 +0000
+++ debian/rules 2010-09-24 20:41:47 +0000
@@ -1,5 +1,7 @@
1#!/usr/bin/make -f1#!/usr/bin/make -f
22
3%:3%:
4 dh $*4 dh --buildsystem=python_distutils --with-addon=python-support $*
55
6override_dh_auto_test:
7 python -m testtools.run hwpack.tests.test_suite
68
=== added file 'setup.py'
--- setup.py 1970-01-01 00:00:00 +0000
+++ setup.py 2010-09-24 20:41:47 +0000
@@ -0,0 +1,24 @@
1from distutils.core import setup
2import os
3import subprocess
4
5
6def get_version():
7 proc = subprocess.Popen(
8 ["dpkg-parsechangelog"],
9 cwd=os.path.abspath(os.path.dirname(__file__)),
10 stdout=subprocess.PIPE)
11 output, _ = proc.communicate()
12 version = None
13 for line in output.split("\n"):
14 if line.startswith("Version: "):
15 version = line.split(" ", 1)[1].strip()
16 assert version is not None, (
17 "Couldn't determine version number from debian changelog")
18
19
20setup(
21 name="hwpack",
22 version=get_version(),
23 packages=["hwpack"],
24 )

Subscribers

People subscribed via source and target branches