Code review comment for lp:~james-w/linaro-image-tools/fix-install-latest-logic

Revision history for this message
Tom Gall (tom-gall) wrote :

+1

Tested with alip, headless and netbook-efl images from today 10/14, 10/14 hardware pack

Works.

Without this patch, mkimage fails with two kernel being passed in. From the log (note the 1006 ANND 1007)

+ sudo mkimage -A arm -O linux -T kernel -C none -a 0x80008000 -e 0x80008000 -n Linux -d /home/tgall/bzr/projects/linaro-image-tools/rsync-speedup/binary/boot/vmlinuz-2.6.35-1006-linaro-omap /home/tgall/bzr/projects/linaro-image-tools/rsync-speedup/binary/boot/vmlinuz-2.6.35-1007-linaro-omap /home/tgall/bzr/projects/linaro-image-tools/rsync-speedup/boot-disc/uImage
Usage: mkimage -l image
          -l ==> list image header information
       mkimage [-x] -A arch -O os -T type -C comp -a addr -e ep -n name -d data_file[:data_file...] image
          -A ==> set architecture to 'arch'
          -O ==> set operating system to 'os'
          -T ==> set image type to 'type'
          -C ==> set compression type 'comp'
          -a ==> set load address to 'addr' (hex)
          -e ==> set entry point to 'ep' (hex)
          -n ==> set image name to 'name'
          -d ==> use image data from 'datafile'
          -x ==> set XIP (execute in place)

« Back to merge proposal