Code review comment for lp:~james-w/linaro-image-tools/architectures-from-config

Revision history for this message
James Westby (james-w) wrote :

On Fri, 03 Sep 2010 05:05:54 -0000, Michael Hudson <email address hidden> wrote:
> Review: Approve
> It all looks fine.
>
> I'm not sure of the motivation for filtering out duplicates in the
> accessor methods -- wouldn't complaining during validation make just
> as much sense?

Yes, it would, but I figured that we should just accept the data as it's
understandable, if wrong. I can make the change if you want.

Thanks,

James

« Back to merge proposal