Code review comment for lp:~james-w/launchpad/expose-blueprints

Revision history for this message
Curtis Hovey (sinzui) wrote :

1. It is fine to export whiteboards because they are used. We vowed to stop adding them because they are a poor substitute for a description/wiki.

2. series goal is...well yuck. I do not have a lot of confidence that this implementation is safe. It must be impossible fo a user to directly change the productseries and distroseries--it is impossible for both to have a series. .proposeGoal() has to be exposed, and .goal is used to retrieve it. I think distroseries and productseries should not be exported. ISeries is the generic type for .goal, there are productseries and distroseries are the two implementers

2.5 likewise, I do not think product and distribution should be exported, target returns the correct value and retarget() allows you to set it. target is ISpecificationTarget

Blueprints uses the view to validate when the model or an interface invarant should be doing the validation. Since I do not see any view changes I think we need a branch to land prior to this one that makes the model safe to export.
* SpecificationRetargetingView knows that names can colide, but the model does not.
* updateLifecycleStatus() is called often when editing a spec, but will users know to do this? I think the design is flawed.

review: Needs Fixing (curtis)

« Back to merge proposal