Merge lp:~james-w/canonical-identity-provider/oops2 into lp:canonical-identity-provider/release
Status: | Merged |
---|---|
Approved by: | James Westby |
Approved revision: | no longer in the source branch. |
Merged at revision: | 734 |
Proposed branch: | lp:~james-w/canonical-identity-provider/oops2 |
Merge into: | lp:canonical-identity-provider/release |
Diff against target: |
159 lines (+74/-14) 7 files modified
.bzrignore (+1/-0) django_project/config_dev/config/devel.cfg (+16/-0) django_project/config_dev/django.wsgi (+16/-13) identityprovider/schema.py (+4/-0) identityprovider/wsgi_handler.py (+32/-0) requirements/install.txt (+4/-0) webui/views/errors.py (+1/-1) |
To merge this branch: | bzr merge lp:~james-w/canonical-identity-provider/oops2 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Ricardo Kirkner (community) | Approve | ||
Review via email: mp+153935@code.launchpad.net |
Commit message
Prepare for moving to v2 of the oops stack.
Description of the change
Hi,
This is the prep that is needed for moving to v2 of the oops stack.
It's not perfect yet, as a limitation in the oops stack means we currently
have to choose between showing the user the id of their oops, and having reliable
delivery if amqp is down. I'm working on fixing that limitation, and we can
adopt that when it is ready so that we don't have to choose.
Some comments:
* There are extra requirements that this brings. They should all be
packaged in CAT already, so I think it should be a case of adding them
to the dependencies packaage and getting them installed?
* It requires some config being set to get the oopses delivered, but the
code won't have a problem if it isn't set. How is the config delivered
to production for SSO?
* I didn't make use of settings.BRAND for the new oopses. I'm not sure what
it is for. However we can adjust the reporter or the template to include
extra information if we like. If the info is dynamic and important to have
then I can add the code for it.
Thanks,
James
Oh, I renamed the wsgi symlink so that I could use it with runserver, as it needs to
import it. I can undo that if it's not correct.
Thanks,
James