Merge lp:~james-page/neutron/grizzly-fix-ppa into lp:~openstack-ubuntu-testing/neutron/grizzly

Proposed by James Page
Status: Merged
Approved by: Yolanda Robla
Approved revision: 141
Merged at revision: 140
Proposed branch: lp:~james-page/neutron/grizzly-fix-ppa
Merge into: lp:~openstack-ubuntu-testing/neutron/grizzly
Diff against target: 218 lines (+53/-39)
3 files modified
debian/changelog (+4/-0)
debian/patches/fix-quantum-configuration.patch (+31/-29)
debian/patches/fix-ubuntu-tests.patch (+18/-10)
To merge this branch: bzr merge lp:~james-page/neutron/grizzly-fix-ppa
Reviewer Review Type Date Requested Status
Yolanda Robla (community) Approve
Review via email: mp+151436@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Yolanda Robla (yolanda.robla) wrote :

Looks good to me

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2013-03-03 22:59:19 +0000
+++ debian/changelog 2013-03-04 09:10:52 +0000
@@ -16,6 +16,10 @@
16 * d/control,quantum-lbaas-*: Added Load Balancing as-a Service agent16 * d/control,quantum-lbaas-*: Added Load Balancing as-a Service agent
17 package. 17 package.
18 * d/control: Bumped Standards-Version, no changes.18 * d/control: Bumped Standards-Version, no changes.
19 * d/p/fix-quantum-configuration.patch: Added midonet sqlite path to
20 patch, fixed up linuxbridge path.
21 * d/p/fix-ubuntu-tests.patch: Re-added skipTest for linuxbridge tests
22 that attempt to setup udev monitors.
1923
20 -- Chuck Short <zulcss@ubuntu.com> Tue, 26 Feb 2013 08:27:14 -060024 -- Chuck Short <zulcss@ubuntu.com> Tue, 26 Feb 2013 08:27:14 -0600
2125
2226
=== modified file 'debian/patches/fix-quantum-configuration.patch'
--- debian/patches/fix-quantum-configuration.patch 2013-02-26 14:32:08 +0000
+++ debian/patches/fix-quantum-configuration.patch 2013-03-04 09:10:52 +0000
@@ -1,6 +1,5 @@
1diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/bigswitch/restproxy.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/bigswitch/restproxy.ini1--- a/etc/quantum/plugins/bigswitch/restproxy.ini
2--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/bigswitch/restproxy.ini 2013-02-26 08:24:56.000000000 -06002+++ b/etc/quantum/plugins/bigswitch/restproxy.ini
3+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/bigswitch/restproxy.ini 2013-02-26 08:29:05.948260373 -0600
4@@ -6,7 +6,7 @@3@@ -6,7 +6,7 @@
5 # sql_connection = mysql://root:pass@127.0.0.1:3306/restproxy_quantum4 # sql_connection = mysql://root:pass@127.0.0.1:3306/restproxy_quantum
6 # Replace 127.0.0.1 above with the IP address of the database used by the5 # Replace 127.0.0.1 above with the IP address of the database used by the
@@ -10,9 +9,8 @@
10 # Database reconnection retry times - in event connectivity is lost9 # Database reconnection retry times - in event connectivity is lost
11 # set to -1 implies an infinite retry count10 # set to -1 implies an infinite retry count
12 # sql_max_retries = 1011 # sql_max_retries = 10
13diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/brocade/brocade.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/brocade/brocade.ini12--- a/etc/quantum/plugins/brocade/brocade.ini
14--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/brocade/brocade.ini 2013-02-26 08:24:56.000000000 -060013+++ b/etc/quantum/plugins/brocade/brocade.ini
15+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/brocade/brocade.ini 2013-02-26 08:29:05.952260373 -0600
16@@ -11,7 +11,7 @@14@@ -11,7 +11,7 @@
17 # ostype = NOS15 # ostype = NOS
18 16
@@ -22,21 +20,19 @@
22 # Enable the use of eventlet's db_pool for MySQL. The flags sql_min_pool_size,20 # Enable the use of eventlet's db_pool for MySQL. The flags sql_min_pool_size,
23 # sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled.21 # sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled.
24 # sql_dbpool_enable = False22 # sql_dbpool_enable = False
25diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini23--- a/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini
26--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini 2013-02-26 08:24:56.000000000 -060024+++ b/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini
27+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/linuxbridge/linuxbridge_conf.ini 2013-02-26 08:29:05.948260373 -0600
28@@ -26,7 +26,7 @@25@@ -26,7 +26,7 @@
29 # sql_connection = mysql://root:nova@127.0.0.1:3306/quantum_linux_bridge26 # sql_connection = mysql://root:nova@127.0.0.1:3306/quantum_linux_bridge
30 # Replace 127.0.0.1 above with the IP address of the database used by the27 # Replace 127.0.0.1 above with the IP address of the database used by the
31 # main quantum server. (Leave it as is if the database runs on this host.)28 # main quantum server. (Leave it as is if the database runs on this host.)
32-sql_connection = sqlite://29-sql_connection = sqlite://
33+sql_connection = sqlite:///var/lib/quantum/linuxbridge.sqlite30+sql_connection = sqlite:////var/lib/quantum/linuxbridge.sqlite
34 # Database reconnection retry times - in event connectivity is lost31 # Database reconnection retry times - in event connectivity is lost
35 # set to -1 implies an infinite retry count32 # set to -1 implies an infinite retry count
36 # sql_max_retries = 1033 # sql_max_retries = 10
37diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/nec/nec.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/nec/nec.ini34--- a/etc/quantum/plugins/nec/nec.ini
38--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/nec/nec.ini 2013-02-26 08:24:56.000000000 -060035+++ b/etc/quantum/plugins/nec/nec.ini
39+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/nec/nec.ini 2013-02-26 08:29:05.948260373 -0600
40@@ -6,7 +6,7 @@36@@ -6,7 +6,7 @@
41 # sql_connection = mysql://root:nova@127.0.0.1:3306/ovs_quantum37 # sql_connection = mysql://root:nova@127.0.0.1:3306/ovs_quantum
42 # Replace 127.0.0.1 above with the IP address of the database used by the38 # Replace 127.0.0.1 above with the IP address of the database used by the
@@ -55,9 +51,8 @@
55 51
56 [SECURITYGROUP]52 [SECURITYGROUP]
57 # Firewall driver for realizing quantum security group function53 # Firewall driver for realizing quantum security group function
58diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/nicira/nvp.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/nicira/nvp.ini54--- a/etc/quantum/plugins/nicira/nvp.ini
59--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/nicira/nvp.ini 2013-02-26 08:24:56.000000000 -060055+++ b/etc/quantum/plugins/nicira/nvp.ini
60+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/nicira/nvp.ini 2013-02-26 08:29:05.948260373 -0600
61@@ -4,7 +4,7 @@56@@ -4,7 +4,7 @@
62 # sql_connection = mysql://root:quantum@127.0.0.1:3306/nvp_quantum57 # sql_connection = mysql://root:quantum@127.0.0.1:3306/nvp_quantum
63 # Replace 127.0.0.1 above with the IP address of the database used by the58 # Replace 127.0.0.1 above with the IP address of the database used by the
@@ -67,9 +62,8 @@
67 # Database reconnection retry times - in event connectivity is lost62 # Database reconnection retry times - in event connectivity is lost
68 # set to -1 implies an infinite retry count63 # set to -1 implies an infinite retry count
69 # sql_max_retries = 1064 # sql_max_retries = 10
70diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini65--- a/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini
71--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini 2013-02-26 08:24:56.000000000 -060066+++ b/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini
72+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/openvswitch/ovs_quantum_plugin.ini 2013-02-26 08:29:05.948260373 -0600
73@@ -4,7 +4,7 @@67@@ -4,7 +4,7 @@
74 # sql_connection = mysql://root:nova@127.0.0.1:3306/ovs_quantum68 # sql_connection = mysql://root:nova@127.0.0.1:3306/ovs_quantum
75 # Replace 127.0.0.1 above with the IP address of the database used by the69 # Replace 127.0.0.1 above with the IP address of the database used by the
@@ -79,9 +73,8 @@
79 # Database reconnection retry times - in event connectivity is lost73 # Database reconnection retry times - in event connectivity is lost
80 # set to -1 implies an infinite retry count74 # set to -1 implies an infinite retry count
81 # sql_max_retries = 1075 # sql_max_retries = 10
82diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/plumgrid/plumgrid.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/plumgrid/plumgrid.ini76--- a/etc/quantum/plugins/plumgrid/plumgrid.ini
83--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/plumgrid/plumgrid.ini 2013-02-26 08:24:56.000000000 -060077+++ b/etc/quantum/plugins/plumgrid/plumgrid.ini
84+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/plumgrid/plumgrid.ini 2013-02-26 08:29:05.948260373 -0600
85@@ -6,7 +6,7 @@78@@ -6,7 +6,7 @@
86 # sql_connection = mysql://<user>:<pass>@<host>:3306/plumgrid_quantum79 # sql_connection = mysql://<user>:<pass>@<host>:3306/plumgrid_quantum
87 # Replace <host> above with the IP address of the database used by the80 # Replace <host> above with the IP address of the database used by the
@@ -91,9 +84,8 @@
91 # Database reconnection retry times - in event connectivity is lost84 # Database reconnection retry times - in event connectivity is lost
92 # set to -1 implies an infinite retry count85 # set to -1 implies an infinite retry count
93 # sql_max_retries = 1086 # sql_max_retries = 10
94diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/ryu/ryu.ini quantum-2013.1.a38.g511ac76/etc/quantum/plugins/ryu/ryu.ini87--- a/etc/quantum/plugins/ryu/ryu.ini
95--- quantum-2013.1.a38.g511ac76.orig/etc/quantum/plugins/ryu/ryu.ini 2013-02-26 08:24:56.000000000 -060088+++ b/etc/quantum/plugins/ryu/ryu.ini
96+++ quantum-2013.1.a38.g511ac76/etc/quantum/plugins/ryu/ryu.ini 2013-02-26 08:29:05.948260373 -0600
97@@ -2,7 +2,7 @@89@@ -2,7 +2,7 @@
98 # This line MUST be changed to actually run the plugin.90 # This line MUST be changed to actually run the plugin.
99 # Example: sql_connection = mysql://root:nova@127.0.0.1:3306/ryu_quantum91 # Example: sql_connection = mysql://root:nova@127.0.0.1:3306/ryu_quantum
@@ -103,9 +95,8 @@
103 # Enable the use of eventlet's db_pool for MySQL. The flags sql_min_pool_size,95 # Enable the use of eventlet's db_pool for MySQL. The flags sql_min_pool_size,
104 # sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled.96 # sql_max_pool_size and sql_idle_timeout are relevant only if this is enabled.
105 # sql_dbpool_enable = False97 # sql_dbpool_enable = False
106diff -Naurp quantum-2013.1.a38.g511ac76.orig/etc/quantum.conf quantum-2013.1.a38.g511ac76/etc/quantum.conf98--- a/etc/quantum.conf
107--- quantum-2013.1.a38.g511ac76.orig/etc/quantum.conf 2013-02-26 08:24:56.000000000 -060099+++ b/etc/quantum.conf
108+++ quantum-2013.1.a38.g511ac76/etc/quantum.conf 2013-02-26 08:29:05.948260373 -0600
109@@ -43,12 +43,13 @@ bind_port = 9696100@@ -43,12 +43,13 @@ bind_port = 9696
110 101
111 # Quantum plugin provider module102 # Quantum plugin provider module
@@ -121,7 +112,7 @@
121 112
122 # The strategy to be used for auth.113 # The strategy to be used for auth.
123 # Supported values are 'keystone'(default), 'noauth'.114 # Supported values are 'keystone'(default), 'noauth'.
124@@ -226,6 +227,7 @@ notification_topics = notifications115@@ -251,6 +252,7 @@ notification_topics = notifications
125 # root filter facility.116 # root filter facility.
126 # Change to "sudo" to skip the filtering and just run the comand directly117 # Change to "sudo" to skip the filtering and just run the comand directly
127 # root_helper = sudo118 # root_helper = sudo
@@ -129,3 +120,14 @@
129 120
130 # =========== items for agent management extension =============121 # =========== items for agent management extension =============
131 # seconds between nodes reporting state to server, should be less than122 # seconds between nodes reporting state to server, should be less than
123--- a/etc/quantum/plugins/midonet/midonet.ini
124+++ b/etc/quantum/plugins/midonet/midonet.ini
125@@ -4,7 +4,7 @@
126 # sql_connection = mysql://root:pass@127.0.0.1:3306/midonet_quantum
127 # Replace 127.0.0.1 above with the IP address of the database used by the
128 # main quantum server. (Leave it as is if the database runs on this host.)
129-sql_connection = sqlite://
130+sql_connection = sqlite:////var/lib/quantum/midonet.sqlite
131 # Database reconnection retry times - in event connectivity is lost
132 # set to -1 implies an infinite retry count
133 # sql_max_retries = 10
132134
=== modified file 'debian/patches/fix-ubuntu-tests.patch'
--- debian/patches/fix-ubuntu-tests.patch 2013-02-27 15:02:09 +0000
+++ debian/patches/fix-ubuntu-tests.patch 2013-03-04 09:10:52 +0000
@@ -1,6 +1,5 @@
1diff -Naurp quantum-2013.1.a49.g598483f.orig/quantum/tests/unit/midonet/test_midonet_plugin.py quantum-2013.1.a49.g598483f/quantum/tests/unit/midonet/test_midonet_plugin.py1--- a/quantum/tests/unit/midonet/test_midonet_plugin.py
2--- quantum-2013.1.a49.g598483f.orig/quantum/tests/unit/midonet/test_midonet_plugin.py 2013-02-27 07:42:40.000000000 -06002+++ b/quantum/tests/unit/midonet/test_midonet_plugin.py
3+++ quantum-2013.1.a49.g598483f/quantum/tests/unit/midonet/test_midonet_plugin.py 2013-02-27 08:59:59.752884924 -0600
4@@ -470,6 +470,7 @@ class TestMidonetSubnetsV2(test_plugin.T3@@ -470,6 +470,7 @@ class TestMidonetSubnetsV2(test_plugin.T
5 self).test_create_subnet_with_one_host_route()4 self).test_create_subnet_with_one_host_route()
6 5
@@ -9,10 +8,9 @@
9 _bridge, _subnet = self._setup_subnet_mocks()8 _bridge, _subnet = self._setup_subnet_mocks()
10 super(TestMidonetSubnetsV2,9 super(TestMidonetSubnetsV2,
11 self).test_create_subnet_with_two_host_routes()10 self).test_create_subnet_with_two_host_routes()
12diff -Naurp quantum-2013.1.a49.g598483f.orig/quantum/tests/unit/test_db_plugin.py quantum-2013.1.a49.g598483f/quantum/tests/unit/test_db_plugin.py11--- a/quantum/tests/unit/test_db_plugin.py
13--- quantum-2013.1.a49.g598483f.orig/quantum/tests/unit/test_db_plugin.py 2013-02-27 07:42:40.000000000 -060012+++ b/quantum/tests/unit/test_db_plugin.py
14+++ quantum-2013.1.a49.g598483f/quantum/tests/unit/test_db_plugin.py 2013-02-27 09:01:30.136884968 -060013@@ -1392,6 +1392,7 @@ fixed_ips=ip_address%%3D%s&fixed_ips=ip_
15@@ -1371,6 +1371,7 @@ fixed_ips=ip_address%%3D%s&fixed_ips=ip_
16 self._delete('ports', port4['port']['id'])14 self._delete('ports', port4['port']['id'])
17 15
18 def test_range_allocation(self):16 def test_range_allocation(self):
@@ -20,7 +18,7 @@
20 with self.subnet(gateway_ip='10.0.0.3',18 with self.subnet(gateway_ip='10.0.0.3',
21 cidr='10.0.0.0/29') as subnet:19 cidr='10.0.0.0/29') as subnet:
22 kwargs = {"fixed_ips":20 kwargs = {"fixed_ips":
23@@ -2270,6 +2271,7 @@ class TestNetworksV2(QuantumDbPluginV2Te21@@ -2291,6 +2292,7 @@ class TestNetworksV2(QuantumDbPluginV2Te
24 class TestSubnetsV2(QuantumDbPluginV2TestCase):22 class TestSubnetsV2(QuantumDbPluginV2TestCase):
25 23
26 def _test_create_subnet(self, network=None, expected=None, **kwargs):24 def _test_create_subnet(self, network=None, expected=None, **kwargs):
@@ -28,7 +26,7 @@
28 keys = kwargs.copy()26 keys = kwargs.copy()
29 keys.setdefault('cidr', '10.0.0.0/24')27 keys.setdefault('cidr', '10.0.0.0/24')
30 keys.setdefault('ip_version', 4)28 keys.setdefault('ip_version', 4)
31@@ -3257,6 +3259,7 @@ class TestSubnetsV2(QuantumDbPluginV2Tes29@@ -3278,6 +3280,7 @@ class TestSubnetsV2(QuantumDbPluginV2Tes
32 host_routes=host_routes)30 host_routes=host_routes)
33 31
34 def test_create_subnet_with_two_host_routes(self):32 def test_create_subnet_with_two_host_routes(self):
@@ -36,7 +34,7 @@
36 gateway_ip = '10.0.0.1'34 gateway_ip = '10.0.0.1'
37 cidr = '10.0.0.0/24'35 cidr = '10.0.0.0/24'
38 allocation_pools = [{'start': '10.0.0.2',36 allocation_pools = [{'start': '10.0.0.2',
39@@ -3361,6 +3364,7 @@ class TestSubnetsV2(QuantumDbPluginV2Tes37@@ -3382,6 +3385,7 @@ class TestSubnetsV2(QuantumDbPluginV2Tes
40 self.assertEqual(res.status_int, 400)38 self.assertEqual(res.status_int, 400)
41 39
42 def test_delete_subnet_with_dns(self):40 def test_delete_subnet_with_dns(self):
@@ -44,3 +42,13 @@
44 gateway_ip = '10.0.0.1'42 gateway_ip = '10.0.0.1'
45 cidr = '10.0.0.0/24'43 cidr = '10.0.0.0/24'
46 dns_nameservers = ['1.2.3.4']44 dns_nameservers = ['1.2.3.4']
45--- a/quantum/tests/unit/linuxbridge/test_lb_quantum_agent.py
46+++ b/quantum/tests/unit/linuxbridge/test_lb_quantum_agent.py
47@@ -26,6 +26,7 @@ class TestLinuxBridge(testtools.TestCase
48
49 def setUp(self):
50 super(TestLinuxBridge, self).setUp()
51+ self.skipTest('No udev access on Ubuntu buildd.')
52 self.addCleanup(cfg.CONF.reset)
53 interface_mappings = {'physnet1': 'eth1'}
54 root_helper = cfg.CONF.AGENT.root_helper

Subscribers

People subscribed via source and target branches