Merge lp:~james-page/juju-deployer/add-machines-in-order into lp:juju-deployer

Proposed by James Page
Status: Merged
Merged at revision: 193
Proposed branch: lp:~james-page/juju-deployer/add-machines-in-order
Merge into: lp:juju-deployer
Diff against target: 12 lines (+1/-1)
1 file modified
deployer/action/importer.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/juju-deployer/add-machines-in-order
Reviewer Review Type Date Requested Status
Tim Van Steenburgh (community) Approve
Review via email: mp+306470@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Tim Van Steenburgh (tvansteenburgh) wrote :
review: Approve
Revision history for this message
James Page (james-page) wrote :

Unfortunately not.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'deployer/action/importer.py'
--- deployer/action/importer.py 2016-07-12 23:43:08 +0000
+++ deployer/action/importer.py 2016-09-22 14:23:58 +0000
@@ -99,7 +99,7 @@
9999
100 if machines:100 if machines:
101 self.log.info("Creating machines...")101 self.log.info("Creating machines...")
102 for machine_name, spec in machines.items():102 for machine_name, spec in sorted(machines.items()):
103 if self.machine_exists(machine_name):103 if self.machine_exists(machine_name):
104 # XXX frankban: do we really want this? The machine104 # XXX frankban: do we really want this? The machine
105 # identifiers as included in v4 bundles are not intended105 # identifiers as included in v4 bundles are not intended

Subscribers

People subscribed via source and target branches