Merge lp:~james-page/cinder/hpclients-fixup into lp:~ubuntu-server-dev/cinder/icehouse

Proposed by James Page
Status: Merged
Approved by: Chuck Short
Approved revision: 164
Merged at revision: 164
Proposed branch: lp:~james-page/cinder/hpclients-fixup
Merge into: lp:~ubuntu-server-dev/cinder/icehouse
Diff against target: 81 lines (+6/-43)
4 files modified
debian/changelog (+4/-1)
debian/control (+2/-1)
debian/patches/series (+0/-1)
debian/patches/skip-tests.patch (+0/-40)
To merge this branch: bzr merge lp:~james-page/cinder/hpclients-fixup
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+207910@code.launchpad.net

Description of the change

Update BD's to fix FTBFS

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Please take a look.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'debian/changelog'
--- debian/changelog 2014-02-13 15:36:59 +0000
+++ debian/changelog 2014-02-24 12:12:39 +0000
@@ -8,7 +8,10 @@
8 packaged yet.8 packaged yet.
99
10 [ James Page ]10 [ James Page ]
11 * debian/patches/fix-requirements.patch: Refreshed.11 * d/p/fix-requirements.patch: Refreshed.
12 * d/control,d/p/series/skip-tests.patch: Add BD on python-hplefthandclient,
13 bump version requirement on python-hp3parclient to >= 3.0.0 and drop
14 patch that skips hplefthandclient tests.
1215
13 -- James Page <james.page@ubuntu.com> Mon, 10 Feb 2014 18:33:54 +020016 -- James Page <james.page@ubuntu.com> Mon, 10 Feb 2014 18:33:54 +0200
1417
1518
=== modified file 'debian/control'
--- debian/control 2014-02-03 15:54:05 +0000
+++ debian/control 2014-02-24 12:12:39 +0000
@@ -13,7 +13,8 @@
13 python-fixtures (>= 0.3.14),13 python-fixtures (>= 0.3.14),
14 python-glanceclient (>= 1:0.9.0),14 python-glanceclient (>= 1:0.9.0),
15 python-greenlet (>= 0.3.2),15 python-greenlet (>= 0.3.2),
16 python-hp3parclient (>= 2.0.0),16 python-hp3parclient (>= 3.0.0),
17 python-hplefthandclient (>= 1.0.0),
17 python-iso8601,18 python-iso8601,
18 python-keystoneclient (>= 1:0.4.2),19 python-keystoneclient (>= 1:0.4.2),
19 python-kombu (>= 2.5.12),20 python-kombu (>= 2.5.12),
2021
=== modified file 'debian/patches/series'
--- debian/patches/series 2014-02-13 15:36:59 +0000
+++ debian/patches/series 2014-02-24 12:12:39 +0000
@@ -1,2 +1,1 @@
1fix-requirements.patch1fix-requirements.patch
2skip-tests.patch
32
=== removed file 'debian/patches/skip-tests.patch'
--- debian/patches/skip-tests.patch 2014-02-13 15:46:07 +0000
+++ debian/patches/skip-tests.patch 1970-01-01 00:00:00 +0000
@@ -1,40 +0,0 @@
1Description: Temporarily skip hplefthand tests.
2Author: Chuck Short <zulcss@ubuntu.com>
3Fowarded: Not Needed
4diff --git a/cinder/tests/test_hplefthand.py b/cinder/tests/test_hplefthand.py
5index 7d3b395..af171eb 100644
6--- a/cinder/tests/test_hplefthand.py
7+++ b/cinder/tests/test_hplefthand.py
8@@ -16,7 +16,10 @@
9 """Unit tests for OpenStack Cinder volume drivers."""
10 import mock
11
12-from hplefthandclient import exceptions as hpexceptions
13+try:
14+ from hplefthandclient import exceptions as hpexceptions
15+except ImportError:
16+ hptlefthandclient = None
17
18 from cinder import exception
19 from cinder.openstack.common import log as logging
20@@ -330,6 +333,8 @@ class TestHPLeftHandCLIQISCSIDriver(HPLeftHandBaseDriver, test.TestCase):
21 return verbs[verb](cliq_args)
22
23 def setUp(self):
24+ if hplefthandclient is None:
25+ self.skipTest('hplefthandclient is not installed')
26 super(TestHPLeftHandCLIQISCSIDriver, self).setUp()
27
28 self.properties = {
29@@ -583,6 +588,8 @@ class TestHPLeftHandRESTISCSIDriver(HPLeftHandBaseDriver, test.TestCase):
30 mock.call.getCluster(1)]
31
32 def setUp(self):
33+ if hplefthandclient is None:
34+ self.skipTest('hplefthandclient is not installed')
35 super(TestHPLeftHandRESTISCSIDriver, self).setUp()
36
37 def tearDown(self):
38--
391.8.3.2
40

Subscribers

People subscribed via source and target branches