Merge lp:~james-page/cinder/hpclients-fixup into lp:~ubuntu-server-dev/cinder/icehouse

Proposed by James Page
Status: Merged
Approved by: Chuck Short
Approved revision: 164
Merged at revision: 164
Proposed branch: lp:~james-page/cinder/hpclients-fixup
Merge into: lp:~ubuntu-server-dev/cinder/icehouse
Diff against target: 81 lines (+6/-43)
4 files modified
debian/changelog (+4/-1)
debian/control (+2/-1)
debian/patches/series (+0/-1)
debian/patches/skip-tests.patch (+0/-40)
To merge this branch: bzr merge lp:~james-page/cinder/hpclients-fixup
Reviewer Review Type Date Requested Status
Ubuntu Server Developers Pending
Review via email: mp+207910@code.launchpad.net

Description of the change

Update BD's to fix FTBFS

To post a comment you must log in.
Revision history for this message
James Page (james-page) wrote :

Please take a look.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'debian/changelog'
2--- debian/changelog 2014-02-13 15:36:59 +0000
3+++ debian/changelog 2014-02-24 12:12:39 +0000
4@@ -8,7 +8,10 @@
5 packaged yet.
6
7 [ James Page ]
8- * debian/patches/fix-requirements.patch: Refreshed.
9+ * d/p/fix-requirements.patch: Refreshed.
10+ * d/control,d/p/series/skip-tests.patch: Add BD on python-hplefthandclient,
11+ bump version requirement on python-hp3parclient to >= 3.0.0 and drop
12+ patch that skips hplefthandclient tests.
13
14 -- James Page <james.page@ubuntu.com> Mon, 10 Feb 2014 18:33:54 +0200
15
16
17=== modified file 'debian/control'
18--- debian/control 2014-02-03 15:54:05 +0000
19+++ debian/control 2014-02-24 12:12:39 +0000
20@@ -13,7 +13,8 @@
21 python-fixtures (>= 0.3.14),
22 python-glanceclient (>= 1:0.9.0),
23 python-greenlet (>= 0.3.2),
24- python-hp3parclient (>= 2.0.0),
25+ python-hp3parclient (>= 3.0.0),
26+ python-hplefthandclient (>= 1.0.0),
27 python-iso8601,
28 python-keystoneclient (>= 1:0.4.2),
29 python-kombu (>= 2.5.12),
30
31=== modified file 'debian/patches/series'
32--- debian/patches/series 2014-02-13 15:36:59 +0000
33+++ debian/patches/series 2014-02-24 12:12:39 +0000
34@@ -1,2 +1,1 @@
35 fix-requirements.patch
36-skip-tests.patch
37
38=== removed file 'debian/patches/skip-tests.patch'
39--- debian/patches/skip-tests.patch 2014-02-13 15:46:07 +0000
40+++ debian/patches/skip-tests.patch 1970-01-01 00:00:00 +0000
41@@ -1,40 +0,0 @@
42-Description: Temporarily skip hplefthand tests.
43-Author: Chuck Short <zulcss@ubuntu.com>
44-Fowarded: Not Needed
45-diff --git a/cinder/tests/test_hplefthand.py b/cinder/tests/test_hplefthand.py
46-index 7d3b395..af171eb 100644
47---- a/cinder/tests/test_hplefthand.py
48-+++ b/cinder/tests/test_hplefthand.py
49-@@ -16,7 +16,10 @@
50- """Unit tests for OpenStack Cinder volume drivers."""
51- import mock
52-
53--from hplefthandclient import exceptions as hpexceptions
54-+try:
55-+ from hplefthandclient import exceptions as hpexceptions
56-+except ImportError:
57-+ hptlefthandclient = None
58-
59- from cinder import exception
60- from cinder.openstack.common import log as logging
61-@@ -330,6 +333,8 @@ class TestHPLeftHandCLIQISCSIDriver(HPLeftHandBaseDriver, test.TestCase):
62- return verbs[verb](cliq_args)
63-
64- def setUp(self):
65-+ if hplefthandclient is None:
66-+ self.skipTest('hplefthandclient is not installed')
67- super(TestHPLeftHandCLIQISCSIDriver, self).setUp()
68-
69- self.properties = {
70-@@ -583,6 +588,8 @@ class TestHPLeftHandRESTISCSIDriver(HPLeftHandBaseDriver, test.TestCase):
71- mock.call.getCluster(1)]
72-
73- def setUp(self):
74-+ if hplefthandclient is None:
75-+ self.skipTest('hplefthandclient is not installed')
76- super(TestHPLeftHandRESTISCSIDriver, self).setUp()
77-
78- def tearDown(self):
79---
80-1.8.3.2
81-

Subscribers

People subscribed via source and target branches