Juju Charms Collection
rabbitmq-server package

Code review comment for lp:~james-page/charms/trusty/rabbitmq-server/status-check

  1. Trusty Tahr (14.04)
  2. status-check
  3. Merge into next
Revision history for this message
David Ames (thedac) wrote :

> However, one of the bugs I am fighting
> (https://bugs.launchpad.net/charms/+source/rabbitmq-server/+bug/1500204) is a
> direct result of checking for more than one running node.
>
> if len(running_nodes()) > 1:
>
> Consider, the 3rd, 4th and 5th nodes to attempt clustering. There will already
> by 2+ running nodes and they will assume incorrectly they are already
> clustered.

Ignore this. I see what it is supposed to do. As the local unit will only ever see 1 if not clustered or more if clustered.

> I plan to merge your MP into my branch and do some more testing and see if I
> can come up with a clustered check that works in all cases.

I am testing a combination of my MP which ignores min-cluster-size when leadership election is available and your MP now. I'll see if any more race conditions reveal themselves.

« Back to merge proposal