Merge lp:~james-page/charms/trusty/rabbitmq-server/config-fixup into lp:charms/trusty/rabbitmq-server

Proposed by James Page
Status: Merged
Merged at revision: 58
Proposed branch: lp:~james-page/charms/trusty/rabbitmq-server/config-fixup
Merge into: lp:charms/trusty/rabbitmq-server
Diff against target: 192 lines (+72/-74)
1 file modified
config.yaml (+72/-74)
To merge this branch: bzr merge lp:~james-page/charms/trusty/rabbitmq-server/config-fixup
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+234260@code.launchpad.net

Description of the change

Ensure default values make sense (dropped "").

Fixup formatting.

To post a comment you must log in.
59. By James Page

Fixup indents

Revision history for this message
Liam Young (gnuoy) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'config.yaml'
--- config.yaml 2014-09-08 18:38:55 +0000
+++ config.yaml 2014-09-11 07:25:07 +0000
@@ -3,7 +3,6 @@
3 type: boolean3 type: boolean
4 default: False4 default: False
5 description: enable the management plugin5 description: enable the management plugin
6
7 # SSL Configuration options6 # SSL Configuration options
8 ssl:7 ssl:
9 type: string8 type: string
@@ -25,18 +24,17 @@
25 ssl_key:24 ssl_key:
26 type: string25 type: string
27 description: private unencrypted key in base64 PEM format (starts "-----BEGIN RSA PRIVATE KEY-----")26 description: private unencrypted key in base64 PEM format (starts "-----BEGIN RSA PRIVATE KEY-----")
28 default: ""27 default:
29 ssl_cert:28 ssl_cert:
30 type: string29 type: string
31 description: X.509 certificate in base64 PEM format (starts "-----BEGIN CERTIFICATE-----")30 description: X.509 certificate in base64 PEM format (starts "-----BEGIN CERTIFICATE-----")
32 default: ""31 default:
33 ssl_ca:32 ssl_ca:
34 type: string33 type: string
35 description: |34 description: |
36 Certificate authority cert that the cert. Optional if the ssl_cert is signed by a ca35 Certificate authority cert that the cert. Optional if the ssl_cert is signed by a ca
37 recognized by the os. Format is base64 PEM (concatenated certs if needed).36 recognized by the os. Format is base64 PEM (concatenated certs if needed).
38 default: ""37 default:
39
40 nagios_context:38 nagios_context:
41 default: "juju"39 default: "juju"
42 type: string40 type: string
@@ -49,62 +47,62 @@
49 this allows you to differentiate between them.47 this allows you to differentiate between them.
50 # HA configuration settings48 # HA configuration settings
51 vip:49 vip:
52 type: string50 type: string
53 description: "Virtual IP to use to front rabbitmq in ha configuration"51 description: "Virtual IP to use to front rabbitmq in ha configuration"
54 default: ""52 default:
55 vip_iface:53 vip_iface:
56 type: string54 type: string
57 default: eth055 default: eth0
58 description: "Network Interface where to place the Virtual IP"56 description: "Network Interface where to place the Virtual IP"
59 vip_cidr:57 vip_cidr:
60 type: int58 type: int
61 default: 2459 default: 24
62 description: "Netmask that will be used for the Virtual IP"60 description: "Netmask that will be used for the Virtual IP"
63 ha-bindiface:61 ha-bindiface:
64 type: string62 type: string
65 default: eth063 default: eth0
66 description: |64 description: |
67 Default network interface on which HA cluster will bind to communication65 Default network interface on which HA cluster will bind to communication
68 with the other members of the HA Cluster.66 with the other members of the HA Cluster.
69 ha-mcastport:67 ha-mcastport:
70 type: int68 type: int
71 default: 540669 default: 5406
72 description: |70 description: |
73 Default multicast port number that will be used to communicate between71 Default multicast port number that will be used to communicate between
74 HA Cluster nodes.72 HA Cluster nodes.
75 ha-vip-only:73 ha-vip-only:
76 type: boolean74 type: boolean
77 default: False75 default: False
78 description: |76 description: |
79 By default, without pairing with hacluster charm, rabbitmq will deploy77 By default, without pairing with hacluster charm, rabbitmq will deploy
80 in active/active/active... HA. When pairied with hacluster charm, it78 in active/active/active... HA. When pairied with hacluster charm, it
81 will deploy as active/passive. By enabling this option, pairing with79 will deploy as active/passive. By enabling this option, pairing with
82 hacluster charm will keep rabbit in active/active setup, but in addition80 hacluster charm will keep rabbit in active/active setup, but in addition
83 it will deploy a VIP that can be used by services that cannot work81 it will deploy a VIP that can be used by services that cannot work
84 with mutiple AMQPs (like Glance in pre-Icehouse).82 with mutiple AMQPs (like Glance in pre-Icehouse).
85 rbd-size:83 rbd-size:
86 type: string84 type: string
87 default: 5G85 default: 5G
88 description: |86 description: |
89 Default rbd storage size to create when setting up block storage.87 Default rbd storage size to create when setting up block storage.
90 This value should be specified in GB (e.g. 100G).88 This value should be specified in GB (e.g. 100G).
91 rbd-name:89 rbd-name:
92 type: string90 type: string
93 default: rabbitmq191 default: rabbitmq1
94 description: |92 description: |
95 The name that will be used to create the Ceph's RBD image with. If the93 The name that will be used to create the Ceph's RBD image with. If the
96 image name exists in Ceph, it will be re-used and the data will be94 image name exists in Ceph, it will be re-used and the data will be
97 overwritten.95 overwritten.
98 ceph-osd-replication-count:96 ceph-osd-replication-count:
99 default: 297 default: 2
100 type: int98 type: int
101 description: |99 description: |
102 This value dictates the number of replicas ceph must make of any100 This value dictates the number of replicas ceph must make of any
103 object it stores within the rabbitmq rbd pool. Of course, this only101 object it stores within the rabbitmq rbd pool. Of course, this only
104 applies if using Ceph as a backend store. Note that once the rabbitmq102 applies if using Ceph as a backend store. Note that once the rabbitmq
105 rbd pool has been created, changing this value will not have any103 rbd pool has been created, changing this value will not have any
106 effect (although it can be changed in ceph by manually configuring104 effect (although it can be changed in ceph by manually configuring
107 your ceph cluster).105 your ceph cluster).
108 use-syslog:106 use-syslog:
109 type: boolean107 type: boolean
110 default: False108 default: False
@@ -112,26 +110,26 @@
112 If True, services that support it will log to syslog instead of their normal110 If True, services that support it will log to syslog instead of their normal
113 log location.111 log location.
114 max-cluster-tries:112 max-cluster-tries:
115 type: int113 type: int
116 default: 3114 default: 3
117 description: |115 description: |
118 Number of tries to cluster with other units before giving up and throwing116 Number of tries to cluster with other units before giving up and throwing
119 a hook error.117 a hook error.
120 source:118 source:
121 type: string119 type: string
122 default:120 default:
123 description: |121 description: |
124 Optional configuration to support use of additional sources such as:122 Optional configuration to support use of additional sources such as:
125 .123 .
126 - ppa:myteam/ppa124 - ppa:myteam/ppa
127 - cloud:precise-proposed/folsom125 - cloud:precise-proposed/folsom
128 - http://my.archive.com/ubuntu main126 - http://my.archive.com/ubuntu main
129 .127 .
130 The last option should be used in conjunction with the key configuration128 The last option should be used in conjunction with the key configuration
131 option.129 option.
132 key:130 key:
133 type: string131 type: string
134 default:132 default:
135 description: |133 description: |
136 Key ID to import to the apt keyring to support use with arbitary source134 Key ID to import to the apt keyring to support use with arbitary source
137 configuration from outside of Launchpad archives or PPA's.135 configuration from outside of Launchpad archives or PPA's.

Subscribers

People subscribed via source and target branches