Merge lp:~james-page/charms/trusty/rabbitmq-server/config-fixup into lp:charms/trusty/rabbitmq-server

Proposed by James Page
Status: Merged
Merged at revision: 58
Proposed branch: lp:~james-page/charms/trusty/rabbitmq-server/config-fixup
Merge into: lp:charms/trusty/rabbitmq-server
Diff against target: 192 lines (+72/-74)
1 file modified
config.yaml (+72/-74)
To merge this branch: bzr merge lp:~james-page/charms/trusty/rabbitmq-server/config-fixup
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+234260@code.launchpad.net

Description of the change

Ensure default values make sense (dropped "").

Fixup formatting.

To post a comment you must log in.
59. By James Page

Fixup indents

Revision history for this message
Liam Young (gnuoy) wrote :

Approved

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'config.yaml'
2--- config.yaml 2014-09-08 18:38:55 +0000
3+++ config.yaml 2014-09-11 07:25:07 +0000
4@@ -3,7 +3,6 @@
5 type: boolean
6 default: False
7 description: enable the management plugin
8-
9 # SSL Configuration options
10 ssl:
11 type: string
12@@ -25,18 +24,17 @@
13 ssl_key:
14 type: string
15 description: private unencrypted key in base64 PEM format (starts "-----BEGIN RSA PRIVATE KEY-----")
16- default: ""
17+ default:
18 ssl_cert:
19 type: string
20 description: X.509 certificate in base64 PEM format (starts "-----BEGIN CERTIFICATE-----")
21- default: ""
22+ default:
23 ssl_ca:
24 type: string
25 description: |
26 Certificate authority cert that the cert. Optional if the ssl_cert is signed by a ca
27 recognized by the os. Format is base64 PEM (concatenated certs if needed).
28- default: ""
29-
30+ default:
31 nagios_context:
32 default: "juju"
33 type: string
34@@ -49,62 +47,62 @@
35 this allows you to differentiate between them.
36 # HA configuration settings
37 vip:
38- type: string
39- description: "Virtual IP to use to front rabbitmq in ha configuration"
40- default: ""
41+ type: string
42+ description: "Virtual IP to use to front rabbitmq in ha configuration"
43+ default:
44 vip_iface:
45- type: string
46- default: eth0
47- description: "Network Interface where to place the Virtual IP"
48+ type: string
49+ default: eth0
50+ description: "Network Interface where to place the Virtual IP"
51 vip_cidr:
52- type: int
53- default: 24
54- description: "Netmask that will be used for the Virtual IP"
55+ type: int
56+ default: 24
57+ description: "Netmask that will be used for the Virtual IP"
58 ha-bindiface:
59- type: string
60- default: eth0
61- description: |
62- Default network interface on which HA cluster will bind to communication
63- with the other members of the HA Cluster.
64+ type: string
65+ default: eth0
66+ description: |
67+ Default network interface on which HA cluster will bind to communication
68+ with the other members of the HA Cluster.
69 ha-mcastport:
70- type: int
71- default: 5406
72- description: |
73- Default multicast port number that will be used to communicate between
74- HA Cluster nodes.
75+ type: int
76+ default: 5406
77+ description: |
78+ Default multicast port number that will be used to communicate between
79+ HA Cluster nodes.
80 ha-vip-only:
81- type: boolean
82- default: False
83- description: |
84- By default, without pairing with hacluster charm, rabbitmq will deploy
85- in active/active/active... HA. When pairied with hacluster charm, it
86- will deploy as active/passive. By enabling this option, pairing with
87- hacluster charm will keep rabbit in active/active setup, but in addition
88- it will deploy a VIP that can be used by services that cannot work
89- with mutiple AMQPs (like Glance in pre-Icehouse).
90+ type: boolean
91+ default: False
92+ description: |
93+ By default, without pairing with hacluster charm, rabbitmq will deploy
94+ in active/active/active... HA. When pairied with hacluster charm, it
95+ will deploy as active/passive. By enabling this option, pairing with
96+ hacluster charm will keep rabbit in active/active setup, but in addition
97+ it will deploy a VIP that can be used by services that cannot work
98+ with mutiple AMQPs (like Glance in pre-Icehouse).
99 rbd-size:
100- type: string
101- default: 5G
102- description: |
103- Default rbd storage size to create when setting up block storage.
104- This value should be specified in GB (e.g. 100G).
105+ type: string
106+ default: 5G
107+ description: |
108+ Default rbd storage size to create when setting up block storage.
109+ This value should be specified in GB (e.g. 100G).
110 rbd-name:
111- type: string
112- default: rabbitmq1
113- description: |
114- The name that will be used to create the Ceph's RBD image with. If the
115- image name exists in Ceph, it will be re-used and the data will be
116- overwritten.
117+ type: string
118+ default: rabbitmq1
119+ description: |
120+ The name that will be used to create the Ceph's RBD image with. If the
121+ image name exists in Ceph, it will be re-used and the data will be
122+ overwritten.
123 ceph-osd-replication-count:
124- default: 2
125- type: int
126- description: |
127- This value dictates the number of replicas ceph must make of any
128- object it stores within the rabbitmq rbd pool. Of course, this only
129- applies if using Ceph as a backend store. Note that once the rabbitmq
130- rbd pool has been created, changing this value will not have any
131- effect (although it can be changed in ceph by manually configuring
132- your ceph cluster).
133+ default: 2
134+ type: int
135+ description: |
136+ This value dictates the number of replicas ceph must make of any
137+ object it stores within the rabbitmq rbd pool. Of course, this only
138+ applies if using Ceph as a backend store. Note that once the rabbitmq
139+ rbd pool has been created, changing this value will not have any
140+ effect (although it can be changed in ceph by manually configuring
141+ your ceph cluster).
142 use-syslog:
143 type: boolean
144 default: False
145@@ -112,26 +110,26 @@
146 If True, services that support it will log to syslog instead of their normal
147 log location.
148 max-cluster-tries:
149- type: int
150- default: 3
151- description: |
152- Number of tries to cluster with other units before giving up and throwing
153- a hook error.
154+ type: int
155+ default: 3
156+ description: |
157+ Number of tries to cluster with other units before giving up and throwing
158+ a hook error.
159 source:
160- type: string
161- default:
162- description: |
163- Optional configuration to support use of additional sources such as:
164- .
165- - ppa:myteam/ppa
166- - cloud:precise-proposed/folsom
167- - http://my.archive.com/ubuntu main
168- .
169- The last option should be used in conjunction with the key configuration
170- option.
171+ type: string
172+ default:
173+ description: |
174+ Optional configuration to support use of additional sources such as:
175+ .
176+ - ppa:myteam/ppa
177+ - cloud:precise-proposed/folsom
178+ - http://my.archive.com/ubuntu main
179+ .
180+ The last option should be used in conjunction with the key configuration
181+ option.
182 key:
183- type: string
184- default:
185- description: |
186- Key ID to import to the apt keyring to support use with arbitary source
187- configuration from outside of Launchpad archives or PPA's.
188+ type: string
189+ default:
190+ description: |
191+ Key ID to import to the apt keyring to support use with arbitary source
192+ configuration from outside of Launchpad archives or PPA's.

Subscribers

People subscribed via source and target branches