Merge lp:~james-page/charms/trusty/quantum-gateway/l2pop-upgrade-break into lp:~openstack-charmers/charms/trusty/quantum-gateway/next

Proposed by James Page
Status: Merged
Merged at revision: 71
Proposed branch: lp:~james-page/charms/trusty/quantum-gateway/l2pop-upgrade-break
Merge into: lp:~openstack-charmers/charms/trusty/quantum-gateway/next
Diff against target: 48 lines (+9/-9)
2 files modified
hooks/quantum_contexts.py (+1/-1)
unit_tests/test_quantum_contexts.py (+8/-8)
To merge this branch: bzr merge lp:~james-page/charms/trusty/quantum-gateway/l2pop-upgrade-break
Reviewer Review Type Date Requested Status
Edward Hope-Morley Approve
OpenStack Charmers Pending
Review via email: mp+237792@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Edward Hope-Morley (hopem) wrote :

lgtm

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'hooks/quantum_contexts.py'
--- hooks/quantum_contexts.py 2014-10-09 14:00:36 +0000
+++ hooks/quantum_contexts.py 2014-10-09 14:17:04 +0000
@@ -106,7 +106,7 @@
106 defaults if it is not present106 defaults if it is not present
107 '''107 '''
108 neutron_settings = {108 neutron_settings = {
109 'l2_population': True,109 'l2_population': False,
110 'overlay_network_type': 'gre',110 'overlay_network_type': 'gre',
111111
112 }112 }
113113
=== modified file 'unit_tests/test_quantum_contexts.py'
--- unit_tests/test_quantum_contexts.py 2014-10-03 11:24:24 +0000
+++ unit_tests/test_quantum_contexts.py 2014-10-09 14:17:04 +0000
@@ -232,7 +232,7 @@
232 'plugin': 'ovs',232 'plugin': 'ovs',
233 'debug': False,233 'debug': False,
234 'verbose': True,234 'verbose': True,
235 'l2_population': True,235 'l2_population': False,
236 'overlay_network_type': 'gre',236 'overlay_network_type': 'gre',
237 })237 })
238238
@@ -368,15 +368,15 @@
368 def test_neutron_api_settings2(self):368 def test_neutron_api_settings2(self):
369 self.relation_ids.return_value = ['foo']369 self.relation_ids.return_value = ['foo']
370 self.related_units.return_value = ['bar']370 self.related_units.return_value = ['bar']
371 self.test_relation.set({'l2-population': False,371 self.test_relation.set({'l2-population': True,
372 'overlay-network-type': 'gre', })372 'overlay-network-type': 'gre', })
373 self.relation_get.side_effect = self.test_relation.get373 self.relation_get.side_effect = self.test_relation.get
374 self.assertEquals(quantum_contexts._neutron_api_settings(),374 self.assertEquals(quantum_contexts._neutron_api_settings(),
375 {'l2_population': True,
376 'overlay_network_type': 'gre'})
377
378 def test_neutron_api_settings_no_apiplugin(self):
379 self.relation_ids.return_value = []
380 self.assertEquals(quantum_contexts._neutron_api_settings(),
375 {'l2_population': False,381 {'l2_population': False,
376 'overlay_network_type': 'gre'})
377
378 def test_neutron_api_settings_no_apiplugin(self):
379 self.relation_ids.return_value = []
380 self.assertEquals(quantum_contexts._neutron_api_settings(),
381 {'l2_population': True,
382 'overlay_network_type': 'gre', })382 'overlay_network_type': 'gre', })

Subscribers

People subscribed via source and target branches