Juju Charms Collection
odl-controller package

Code review comment for lp:~james-page/charms/trusty/odl-controller/profiles

  1. Trusty Tahr (14.04)
  2. profiles
  3. Merge into trunk
Revision history for this message
Robert Ayres (robert-ayres) wrote :

Minor comments:
* Use double quotes (") for strings everywhere.
* Use .format() over % for string formatting.
* Remove the empty 'default:' attributes from config.yaml where there is no default.

Otherwise, +1 to merge.

review: Approve

« Back to merge proposal