Merge lp:~james-page/charms/trusty/ceilometer/tox into lp:~openstack-charmers-archive/charms/trusty/ceilometer/next

Proposed by James Page
Status: Merged
Merged at revision: 105
Proposed branch: lp:~james-page/charms/trusty/ceilometer/tox
Merge into: lp:~openstack-charmers-archive/charms/trusty/ceilometer/next
Diff against target: 98 lines (+60/-1)
6 files modified
.bzrignore (+3/-0)
.testr.conf (+8/-0)
requirements.txt (+11/-0)
test-requirements.txt (+8/-0)
tests/basic_deployment.py (+1/-1)
tox.ini (+29/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/ceilometer/tox
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Review via email: mp+276370@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Code looks good, I just want to run tests before landing.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

The usual osci tests didn't reported back but I'm going to land this because tox tests are running successfully as well as make lint/test. These changes won't affect amulet tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2014-07-02 08:05:06 +0000
+++ .bzrignore 2015-11-02 09:43:34 +0000
@@ -1,2 +1,5 @@
1bin1bin
2.coverage2.coverage
3.testrepository
4.tox
5tags
36
=== added file '.testr.conf'
--- .testr.conf 1970-01-01 00:00:00 +0000
+++ .testr.conf 2015-11-02 09:43:34 +0000
@@ -0,0 +1,8 @@
1[DEFAULT]
2test_command=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
3 OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
4 OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} \
5 ${PYTHON:-python} -m subunit.run discover -t ./ ./unit_tests $LISTOPT $IDOPTION
6
7test_id_option=--load-list $IDFILE
8test_list_option=--list
09
=== added file 'requirements.txt'
--- requirements.txt 1970-01-01 00:00:00 +0000
+++ requirements.txt 2015-11-02 09:43:34 +0000
@@ -0,0 +1,11 @@
1# The order of packages is significant, because pip processes them in the order
2# of appearance. Changing the order has an impact on the overall integration
3# process, which may cause wedges in the gate later.
4PyYAML>=3.1.0
5simplejson>=2.2.0
6netifaces>=0.10.4
7netaddr>=0.7.12,!=0.7.16
8Jinja2>=2.6 # BSD License (3 clause)
9six>=1.9.0
10dnspython>=1.12.0
11psutil>=1.1.1,<2.0.0
012
=== added file 'test-requirements.txt'
--- test-requirements.txt 1970-01-01 00:00:00 +0000
+++ test-requirements.txt 2015-11-02 09:43:34 +0000
@@ -0,0 +1,8 @@
1# The order of packages is significant, because pip processes them in the order
2# of appearance. Changing the order has an impact on the overall integration
3# process, which may cause wedges in the gate later.
4coverage>=3.6
5mock>=1.2
6flake8>=2.2.4,<=2.4.1
7os-testr>=0.4.1
8charm-tools
09
=== modified file 'tests/basic_deployment.py'
--- tests/basic_deployment.py 2015-10-20 03:13:07 +0000
+++ tests/basic_deployment.py 2015-11-02 09:43:34 +0000
@@ -506,7 +506,7 @@
506 'auth_uri': auth_uri,506 'auth_uri': auth_uri,
507 'auth_host': ks_rel['auth_host'],507 'auth_host': ks_rel['auth_host'],
508 'auth_port': ks_rel['auth_port'],508 'auth_port': ks_rel['auth_port'],
509 'auth_protocol': ks_rel['auth_protocol'],509 'auth_protocol': ks_rel['auth_protocol'],
510 'admin_tenant_name': 'services',510 'admin_tenant_name': 'services',
511 'admin_user': 'ceilometer',511 'admin_user': 'ceilometer',
512 'admin_password': ks_rel['service_password'],512 'admin_password': ks_rel['service_password'],
513513
=== added file 'tox.ini'
--- tox.ini 1970-01-01 00:00:00 +0000
+++ tox.ini 2015-11-02 09:43:34 +0000
@@ -0,0 +1,29 @@
1[tox]
2envlist = lint,py27
3skipsdist = True
4
5[testenv]
6setenv = VIRTUAL_ENV={envdir}
7 PYTHONHASHSEED=0
8install_command =
9 pip install --allow-unverified python-apt {opts} {packages}
10commands = ostestr {posargs}
11
12[testenv:py27]
13basepython = python2.7
14deps = -r{toxinidir}/requirements.txt
15 -r{toxinidir}/test-requirements.txt
16
17[testenv:lint]
18basepython = python2.7
19deps = -r{toxinidir}/requirements.txt
20 -r{toxinidir}/test-requirements.txt
21commands = flake8 {posargs} hooks unit_tests tests actions
22 charm proof
23
24[testenv:venv]
25commands = {posargs}
26
27[flake8]
28ignore = E402,E226
29exclude = hooks/charmhelpers

Subscribers

People subscribed via source and target branches