Merge lp:~james-page/charms/trusty/ceilometer/tox into lp:~openstack-charmers-archive/charms/trusty/ceilometer/next

Proposed by James Page
Status: Merged
Merged at revision: 105
Proposed branch: lp:~james-page/charms/trusty/ceilometer/tox
Merge into: lp:~openstack-charmers-archive/charms/trusty/ceilometer/next
Diff against target: 98 lines (+60/-1)
6 files modified
.bzrignore (+3/-0)
.testr.conf (+8/-0)
requirements.txt (+11/-0)
test-requirements.txt (+8/-0)
tests/basic_deployment.py (+1/-1)
tox.ini (+29/-0)
To merge this branch: bzr merge lp:~james-page/charms/trusty/ceilometer/tox
Reviewer Review Type Date Requested Status
Corey Bryant (community) Approve
Review via email: mp+276370@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Corey Bryant (corey.bryant) wrote :

Code looks good, I just want to run tests before landing.

Revision history for this message
Corey Bryant (corey.bryant) wrote :

The usual osci tests didn't reported back but I'm going to land this because tox tests are running successfully as well as make lint/test. These changes won't affect amulet tests.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file '.bzrignore'
2--- .bzrignore 2014-07-02 08:05:06 +0000
3+++ .bzrignore 2015-11-02 09:43:34 +0000
4@@ -1,2 +1,5 @@
5 bin
6 .coverage
7+.testrepository
8+.tox
9+tags
10
11=== added file '.testr.conf'
12--- .testr.conf 1970-01-01 00:00:00 +0000
13+++ .testr.conf 2015-11-02 09:43:34 +0000
14@@ -0,0 +1,8 @@
15+[DEFAULT]
16+test_command=OS_STDOUT_CAPTURE=${OS_STDOUT_CAPTURE:-1} \
17+ OS_STDERR_CAPTURE=${OS_STDERR_CAPTURE:-1} \
18+ OS_TEST_TIMEOUT=${OS_TEST_TIMEOUT:-60} \
19+ ${PYTHON:-python} -m subunit.run discover -t ./ ./unit_tests $LISTOPT $IDOPTION
20+
21+test_id_option=--load-list $IDFILE
22+test_list_option=--list
23
24=== added file 'requirements.txt'
25--- requirements.txt 1970-01-01 00:00:00 +0000
26+++ requirements.txt 2015-11-02 09:43:34 +0000
27@@ -0,0 +1,11 @@
28+# The order of packages is significant, because pip processes them in the order
29+# of appearance. Changing the order has an impact on the overall integration
30+# process, which may cause wedges in the gate later.
31+PyYAML>=3.1.0
32+simplejson>=2.2.0
33+netifaces>=0.10.4
34+netaddr>=0.7.12,!=0.7.16
35+Jinja2>=2.6 # BSD License (3 clause)
36+six>=1.9.0
37+dnspython>=1.12.0
38+psutil>=1.1.1,<2.0.0
39
40=== added file 'test-requirements.txt'
41--- test-requirements.txt 1970-01-01 00:00:00 +0000
42+++ test-requirements.txt 2015-11-02 09:43:34 +0000
43@@ -0,0 +1,8 @@
44+# The order of packages is significant, because pip processes them in the order
45+# of appearance. Changing the order has an impact on the overall integration
46+# process, which may cause wedges in the gate later.
47+coverage>=3.6
48+mock>=1.2
49+flake8>=2.2.4,<=2.4.1
50+os-testr>=0.4.1
51+charm-tools
52
53=== modified file 'tests/basic_deployment.py'
54--- tests/basic_deployment.py 2015-10-20 03:13:07 +0000
55+++ tests/basic_deployment.py 2015-11-02 09:43:34 +0000
56@@ -506,7 +506,7 @@
57 'auth_uri': auth_uri,
58 'auth_host': ks_rel['auth_host'],
59 'auth_port': ks_rel['auth_port'],
60- 'auth_protocol': ks_rel['auth_protocol'],
61+ 'auth_protocol': ks_rel['auth_protocol'],
62 'admin_tenant_name': 'services',
63 'admin_user': 'ceilometer',
64 'admin_password': ks_rel['service_password'],
65
66=== added file 'tox.ini'
67--- tox.ini 1970-01-01 00:00:00 +0000
68+++ tox.ini 2015-11-02 09:43:34 +0000
69@@ -0,0 +1,29 @@
70+[tox]
71+envlist = lint,py27
72+skipsdist = True
73+
74+[testenv]
75+setenv = VIRTUAL_ENV={envdir}
76+ PYTHONHASHSEED=0
77+install_command =
78+ pip install --allow-unverified python-apt {opts} {packages}
79+commands = ostestr {posargs}
80+
81+[testenv:py27]
82+basepython = python2.7
83+deps = -r{toxinidir}/requirements.txt
84+ -r{toxinidir}/test-requirements.txt
85+
86+[testenv:lint]
87+basepython = python2.7
88+deps = -r{toxinidir}/requirements.txt
89+ -r{toxinidir}/test-requirements.txt
90+commands = flake8 {posargs} hooks unit_tests tests actions
91+ charm proof
92+
93+[testenv:venv]
94+commands = {posargs}
95+
96+[flake8]
97+ignore = E402,E226
98+exclude = hooks/charmhelpers

Subscribers

People subscribed via source and target branches