Code review comment for lp:~james-page/charms/precise/nova-cloud-controller/vmware-nsx

Revision history for this message
Chris Glass (tribaal) wrote :

[1]
Lines 66 and 67 in the diff are not equivalent: are we sure we won't have to check in config("neutron-plugin") as well?
I would defensively add the check as well, like:

in_quantum = config('quantum-plugin') in ['nvp', 'nsx']
in_neutron = config('neutron-plugin') in ['nvp', 'nsx']

if in_quantum or in_neutron:
    ...

« Back to merge proposal