Code review comment for lp:~james-page/charm-helpers/pikeandqueens

Revision history for this message
Alex Kavanagh (ajkavanagh) wrote :

I think that the following also needs updating as part of the same commit:

- charmhelpers/core/host_factory/ubuntu.py -- L#20 probably needs 'artful' adding.
- charmhelpers/contrib/openstack/amulet/deployment.py -- around L#276 in the methods _get_openstack_release() and _get_openstack_release_string()

This functions also relate to OpenStack and Ubuntu releases.

review: Needs Fixing

« Back to merge proposal