Code review comment for lp:~james-page/charm-helpers/inteli-restart

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Looks good, couple of small things:

- White space in tests, comments in restart_on_change() are missing indents.
- Definitely no blocker but test_file_hash_exist could mock out the hashlib stuff so the test isn't testing actual md5 calculation, just that the hexdigest() is being returned correctly to caller.

« Back to merge proposal