Merge lp:~james-page/charm-helpers/bug-1413862-stable into lp:~openstack-charmers/charm-helpers/stable-1604

Proposed by James Page
Status: Merged
Merged at revision: 298
Proposed branch: lp:~james-page/charm-helpers/bug-1413862-stable
Merge into: lp:~openstack-charmers/charm-helpers/stable-1604
Diff against target: 25 lines (+2/-2)
2 files modified
charmhelpers/contrib/openstack/context.py (+1/-1)
tests/contrib/openstack/test_os_contexts.py (+1/-1)
To merge this branch: bzr merge lp:~james-page/charm-helpers/bug-1413862-stable
Reviewer Review Type Date Requested Status
Liam Young (community) Approve
Review via email: mp+251435@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Liam Young (gnuoy) wrote :

Approve

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'charmhelpers/contrib/openstack/context.py'
--- charmhelpers/contrib/openstack/context.py 2015-01-22 06:11:15 +0000
+++ charmhelpers/contrib/openstack/context.py 2015-03-02 12:15:12 +0000
@@ -191,7 +191,7 @@
191 unit=local_unit())191 unit=local_unit())
192 if set_hostname != access_hostname:192 if set_hostname != access_hostname:
193 relation_set(relation_settings={hostname_key: access_hostname})193 relation_set(relation_settings={hostname_key: access_hostname})
194 return ctxt # Defer any further hook execution for now....194 return None # Defer any further hook execution for now....
195195
196 password_setting = 'password'196 password_setting = 'password'
197 if self.relation_prefix:197 if self.relation_prefix:
198198
=== modified file 'tests/contrib/openstack/test_os_contexts.py'
--- tests/contrib/openstack/test_os_contexts.py 2015-01-13 11:56:51 +0000
+++ tests/contrib/openstack/test_os_contexts.py 2015-03-02 12:15:12 +0000
@@ -457,7 +457,7 @@
457 self.config.side_effect = fake_config(SHARED_DB_CONFIG)457 self.config.side_effect = fake_config(SHARED_DB_CONFIG)
458 shared_db = context.SharedDBContext()458 shared_db = context.SharedDBContext()
459 result = shared_db()459 result = shared_db()
460 self.assertEquals(result, {})460 self.assertEquals(result, None)
461 self.relation_set.assert_called_with(461 self.relation_set.assert_called_with(
462 relation_settings={462 relation_settings={
463 'hostname': '10.5.5.1'})463 'hostname': '10.5.5.1'})

Subscribers

People subscribed via source and target branches