Code review comment for lp:~jameinel/loggerhead/remove-head-middleware-758618

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 04/13/2011 03:55 AM, Martin Pool wrote:
> Review: Approve
> Well, it would be nice to fix it properly but I see your point.
>
> Will this have the consequence that HEAD requests will regress to sending the whole body? Perhaps we should reopen the bug for that then?
>
> (approve conditional on reopening the bug if appropriate.)

The HEAD requests we really care about have already been updated.
(Everything that inherits from TemplatedBranchView will not expand the
template.) I think /download would still send body content (because
while it does inherit, it doesn't actually use a Template, it just sends
the raw content as a 'download' attachment.)

For *launchpad* Apache is used as a proxy for Loggerhead, so the public
side already never returns body content for a HEAD request, because
Apache squelches it.

So for small projects that use "bzr serve --http", there are probably a
couple requests that can yield body content for a HEAD request, but I
don't specifically know which ones those would be.

I'm happy to (re)open a bug.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk2lUgsACgkQJdeBCYSNAAP2YQCfTSL8W6TvzLjVcWIbHftzzwGc
CFQAmwQHMXg67a5tG2f4itHHI++0OP/L
=1PiY
-----END PGP SIGNATURE-----