Code review comment for lp:~jameinel/loggerhead/pygment-annotate-fail

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On 2/11/2011 12:29 PM, Benji York wrote:
> Review: Approve code*
> The "with.*<.*htmlspecialchars" regex feels a bit too liberal. How
> about something like this?
>
> # remove any pygments-inserted tags
> body = re.sub('<[^>]+>', '', res.body)
> self.assertContains(body, "with&lt;htmlspecialchars")
>
> Also, I suspect judicious use of a clean Python and buildout would help
> with this scenario, providing reproducible builds isolated from the
> environment. If you're interested I'd be glad to help craft a buildout
> for the project.

The thing is, we *want* pygments to be installed for Loggerhead, so that
it can highlight source code when you are looking at the View content pages.

It is just a soft dependency. If we had a PQM testing loggerhead trunk,
we would want it to be there.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk1VuG4ACgkQJdeBCYSNAAPu4QCg07Wxew98U8Xgsm+xIaMZzpPQ
hUoAoL7jF1N5qTOUCdeyQWz/Y/3esJoN
=G10t
-----END PGP SIGNATURE-----